Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

[1.9.x] CI improvements for Deps #455

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Conversation

scottarnette
Copy link
Contributor

Change Description

Modified behavior of Contracts builds regarding the specified EOSIO dependency in the pipeline.jsonc file:

  • Contracts now builds explicitly with the EOSIO dependency listed in pipeline.jsonc.
    • Buildkite CI no longer uses converted branch/tag names ($EOSIO_VERSION) into commit hashes ($EOSIO_COMMIT) to pull Docker containers.
    • We instead pull Docker containers based on the sanitized ($EOSIO_VERSION) input.
    • This results in fewer occurrences of wait times for builds when the EOSIO dependency is specified by branch/tag name.
    • If the EOSIO dependency is specified by commit hash, CI will still wait if it doesn't already exist.
    • No changes made to CDT dependencies at this time.
  • Improved environment logging.
    • Don't trim commit hashes in log output.
    • Log exact Docker command used in test steps.
    • Log installed EOSIO version in Docker container by commit hash.
    • Dynamically log URL pointing to expected EOSIO build location by branch or commit as needed.

See:
Build 1076 | Build with pre-existing EOSIO and CDT artifact defined by commit hash. Container pulled as specified by commit hash.
Build 1077 | Build with pre-existing EOSIO and CDT artifact defined by branch name. Container pulled as specified by branch.
Build 1078 | Build with pre-existing EOSIO and CDT artifact defined by tag name. Container pulled as specified by tag.
Build 1079 | Build with non-existing EOSIO artifact defined by commit. Contract build waits for artifact to appear.
Build 1080 | Build with non-existing EOSIO artifact defined by branch. Contract build waits for artifact to appear.
Build 1081 | Build with EOSIO artifact defined by branch that has a build in progress. Container pulled based on branch name, but one commit behind as expected to avoid waiting.
Actions | Actions build ensuring no CI regressions for forks.

Deployment Changes

  • Deployment Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@scottarnette scottarnette merged commit e8e9040 into release/1.9.x Feb 6, 2020
@scottarnette scottarnette deleted the cicd-docker-fix-r1.9 branch February 6, 2020 22:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants