This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Fix link on README.md - 1.9 #477
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lparisc
added
the
documentation
iamveritas
reviewed
Mar 10, 2020
| To build the contracts follow the instructions in [`Build and deploy` section](./docs/02_build-and-deploy.md). | ||
| ## Build | ||
|
|
||
| To build the contracts follow the instructions in [Build and deploy](https://developers.eos.io/manuals/eosio.contracts/latest/build-and-deploy) section. |
There was a problem hiding this comment.
FYI: this should be
https://developers.eos.io/manuals/eosio.contracts/v1.9/build-and-deploy, it should not contain latest because this fix is specific for v1.9 version, and as it is now it will always point to latest, and we do not want that when let's say v2.0 will be deployed we want this v1.9 page to point to the corresponding v1.9 build and deploy procedure; however because of this current issue we can not use the correct link.
There was a problem hiding this comment.
Agreed - it is what it is right now
iamveritas
approved these changes
Mar 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Parallel PR #476
Resolves #475
Deployment Changes
API Changes
Documentation Additions