Remove reference to eosjs-ecc and add tests for new logic #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlamarr22
commented
Dec 10, 2019
| @@ -25,20 +25,21 @@ | |||
| "@babel/core": "7.6.0", | |||
| "@babel/preset-env": "7.2.3", | |||
| "@babel/preset-react": "7.0.0", | |||
| "@ledgerhq/hw-transport": "4.48.0", | |||
| "@ledgerhq/hw-transport-u2f": "4.48.0", | |||
| "@ledgerhq/hw-transport": "5.0.0-babel7.3", | |||
There was a problem hiding this comment.
These need to be updated due to this issue that's been open for a long time: LedgerHQ/ledgerjs#332, JoinColony/purser#184
This has a fix with an open PR: LedgerHQ/ledgerjs#241
jlamarr22
force-pushed
the
remove-eosjs-ecc-references
branch
from
f8a80ed to
446e71b
Compare
jeffreyssmith2nd
approved these changes
Dec 11, 2019
some change Refactor New version Fix linting
jlamarr22
force-pushed
the
remove-eosjs-ecc-references
branch
from
446e71b to
8a4d0fd
Compare
This was referenced Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Remove reference to eosjs-ecc and add tests for new logic
API Changes
Documentation Additions