Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

add get_table_by_scope to eosjs #514

Merged
merged 2 commits into from
Mar 7, 2019
Merged

add get_table_by_scope to eosjs #514

merged 2 commits into from
Mar 7, 2019

Conversation

wuyahuang
Copy link
Contributor

@wuyahuang wuyahuang commented Mar 6, 2019 •
edited
Loading

@wuyahuang wuyahuang mentioned this pull request Mar 6, 2019
Closed
@jeffreyssmith2nd
Copy link
Contributor

This looks great, thanks for contributing! Before merging, can you add a test for this new function similar to the one for get_table_rows? https://github.com/EOSIO/eosjs/blob/develop/src/tests/eosjs-jsonrpc.test.ts#L382

@wuyahuang
Copy link
Contributor Author

updated.

@jeffreyssmith2nd
Copy link
Contributor

Great work, thanks!

@jeffreyssmith2nd jeffreyssmith2nd merged commit ac84c38 into EOSIO:develop Mar 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wuyahuang @jeffreyssmith2nd