Update eosio.rb #55
Update eosio.rb #55
Conversation
Added dependencies and the universal option which ultimately resolves issue 50
|
Thank you @georgipopivanov. I was aware of the additional disparities, but being a new contributor, I wasn't sure if it was my place to make all those changes at one time. I appreciate the help in getting this squared away. |
|
I don't think this is the right location to make changes. I believe the file is auto populated from |
|
ah Zach already mentioned something similar in #50 (comment) |
There was a problem hiding this comment.
Thank you so much for contributing, this is helpful! I just found one mistake below.
As @spoonincode mentioned, this will only fix the issue until the next release because the CI system will automatically overwrite this ruby file using packaging scripts in EOSIO here. We still want to merge this to suppress the brew warnings for the current release, but the same changes will have to be made there on eos:develop, eos:release/2.1.x, and eos:release/2.0.x to persist. That would be a worthwhile contribution for anyone interested.
eosio.rb
Outdated
| root_url "https://github.com/eosio/eos/releases/download/v2.0.12" | ||
| sha256 mojave: "2e03b4fe73e0cdc70e607b35e35294f49d6833439176b4dedc846e62a3b77005" |
There was a problem hiding this comment.
This is still pointing to v2.0.12 and should be updated to v2.1.0.
$ openssl dgst -sha256 eosio-2.1.0.mojave.bottle.tar.gz
SHA256(eosio-2.1.0.mojave.bottle.tar.gz)= c3f66cdf5fb02469a9e8d11cb2637eb347ba44b2b68ef77d84bdb1401d6bb685
$ openssl dgst -sha256 eosio-2.1.0.catalina.bottle.tar.gz
SHA256(eosio-2.1.0.catalina.bottle.tar.gz)= b1562e0e2d97288104839884871212d4c2ab1b54b0764aa9bb5f24bb1d5d37ab| depends_on macos: :mojave | ||
| depends_on "openssl@1.1" | ||
| def install | ||
| raise "Error, only supporting binary packages at this time" |
There was a problem hiding this comment.
Could it be useful to link to documentation on building from source here? I assume this exception would bubble up to a terminal window, but not really sure.
I have created a PR for this |
|
We prefer to give community contributors more time to address peer-review feedback, but this warning is impacting all EOSIO users installing via homebrew and it has been a week so I just went ahead and made the bug fix so we can get it merged. Thank you to @gleehokie and @wly99 for reporting this issue, and to @georgipopivanov and @killshot13 for putting up fixes. We really appreciate it, that was the hard part. |
Added dependencies and the universal option which ultimately resolves issue 50