Support local tap

[williamblevins]

Since this is running against 2.1.0, Catalina is going to fail because of the postgres its using.

• Tested against 2.2.0-rc1 hacked file: https://buildkite.com/EOSIO/homebrew-eosio/builds/40#_
• Tested with bad SHA1: https://buildkite.com/EOSIO/homebrew-eosio/builds/39#_

[sandie06]

Just realized the CI builds failed

./homebrew-eosio/.ci/libfunctions.sh: line 31: 56356 Terminated: 15          python3 -m http.server 7800
--
  | # ↳ Command completed in 2m59.851716371s
  | 🚨 Error: The command exited with status 3

[williamblevins]

Just realized the CI builds failed

./homebrew-eosio/.ci/libfunctions.sh: line 31: 56356 Terminated: 15          python3 -m http.server 7800
--
  | # ↳ Command completed in 2m59.851716371s
  | 🚨 Error: The command exited with status 3

That test will fail against EOSIO 2.1.0. The initial release doesn't have the postgres fixes in it.

[kj4ezj]

Overall, looking really good. Fundamentally, I kicked it back because the pipeline documentation isn't up-to-date. It still talks about only running on master. You might also want to review the stuff the documentation is saying we are testing to make sure it is still accurate (after review, I believe it is). Finally, I would add a note or paragraph or section explaining how the staging (non-master) builds are different than the production (master) builds.

[kj4ezj]

UX - I like how you moved the git clone of eos later in the script so that we don't have to wait for it unless we are actually using it. However, this will dump hundreds or thousands of lines of nonsense into the expanded log-folding group containing the test. Can we either suppress the output, put it into a folded log group (which is difficult because we're in the middle of the test one), or move it back to the Configuring Environment group? I think suppressing the output is probably the best option of the three.

perform "git clone --recursive --single-branch --branch '${GIT_TAG}' --quiet '${REPO_UNDER_TEST}' > /dev/null"

Better yet, support disabling this for debugging.

perform "git clone --recursive --single-branch --branch$([[ "$DEBUG" != 'true' ]] || echo ' --quiet') '${GIT_TAG}' '${REPO_UNDER_TEST}'$([[ "$DEBUG" != 'true' ]] || echo ' > /dev/null')"

Not sure if both --quiet and > /dev/null are needed, but this example used both and the man page explicitly states that --quiet stops git from printing progress to STDERR, with no mention of STDOUT.

[williamblevins]

This doesn't seem like a reason to hold up a PR.

[williamblevins]

Since this isn't part of the package builder step verification chain, I can cut all the localhost bottle serving out which by default addresses a lot of this...

• Redo 2.2.0-rc1 test: https://buildkite.com/EOSIO/homebrew-eosio/builds/45

[kj4ezj]

🍺