Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable sccache and ccache for Linking #24

Merged
merged 2 commits into from
Jun 19, 2019
Merged

Disable sccache and ccache for Linking #24

merged 2 commits into from
Jun 19, 2019

Conversation

kj4ezj
Copy link

@kj4ezj kj4ezj commented Jun 19, 2019

In pull request 23, I added support for sccache and ccache for both compiling and linking.

However, I have since learned that sccache does not support linking and will fail when ar is called. This got me to investigate ccache, which also provides no benefit to linker steps, even when you try to compile and link in one step.

So, I have removed the RULE_LAUNCH_LINK for both sccache and ccache, and performed a successful local build.

@kj4ezj kj4ezj requested a review from larryk85 June 19, 2019 21:30
@kj4ezj kj4ezj marked this pull request as ready for review June 19, 2019 21:42
@kj4ezj kj4ezj merged commit ce49c87 into master Jun 19, 2019
@kj4ezj kj4ezj deleted the zach-sccache branch June 19, 2019 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants