Fix for scale_reservoirs #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated keyword "sector" to "demand" to match documentation.
Fixed issue with marginal water value calculations if `rundata.scale_reservoirs` is not 1.
Fix for how contingent storage with modelled when `rundata.scale_reservoirs` is not 1.
|
Hmm. The test failures with |
|
See odow/SDDP.jl#662. I added it in the wrong place |
|
Should be fixed by JuliaRegistries/General#91019 |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #44 +/- ##
=======================================
Coverage 71.35% 71.35%
=======================================
Files 18 18
Lines 2126 2126
=======================================
Hits 1517 1517
Misses 609 609
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more 📢 Have feedback on the report? Share it here. |
odow
approved these changes
Sep 8, 2023
|
cc @adow031 happy with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes in a couple of places when using the scale_reservoirs option.