Update xml comments and removed some unused imports.

src/EPPlus/Core/CellStore/RangeDictionary.cs

@@ -17,6 +17,7 @@ namespace OfficeOpenXml.Core.CellStore
     /// <summary>
     /// This class stores ranges to keep track if they have been accessed before and adds a reference to <see cref="T"/>.
     /// </summary>
+    /// <typeparam name="T">Type type used in the RangeDictionary</typeparam>
     internal class RangeDictionary<T>
     {
         internal struct RangeItem : IComparable<RangeItem>

src/EPPlus/DataValidation/ExcelDataValidation.cs

@@ -28,12 +28,13 @@ namespace OfficeOpenXml.DataValidation
     /// </summary>
     public abstract class ExcelDataValidation : IExcelDataValidation
     {
-            /// <summary>
-            /// Constructor
-            /// </summary>
-            /// <param name="uid">Id for validation</param>
-            /// <param name="address">adress validation is applied to</param>
-            protected ExcelDataValidation(string uid, string address, ExcelWorksheet ws)
+        /// <summary>
+        /// Constructor
+        /// </summary>
+        /// <param name="uid">Id for validation</param>
+        /// <param name="address">adress validation is applied to</param>
+        /// <param name="ws">The worksheet</param>
+        protected ExcelDataValidation(string uid, string address, ExcelWorksheet ws)
         {
             Require.Argument(uid).IsNotNullOrEmpty("uid");
             Require.Argument(address).IsNotNullOrEmpty("address");
@@ -47,6 +48,7 @@ protected ExcelDataValidation(string uid, string address, ExcelWorksheet ws)
         /// Read-File Constructor
         /// </summary>
         /// <param name="xr"></param>
+        /// <param name="ws">The worksheet</param>
         protected ExcelDataValidation(XmlReader xr, ExcelWorksheet ws)
         {
             LoadXML(xr);
@@ -57,6 +59,7 @@ protected ExcelDataValidation(XmlReader xr, ExcelWorksheet ws)
         /// Copy-Constructor
         /// </summary>
         /// <param name="validation">Validation to copy from</param>
+        /// <param name="ws">The worksheet</param>
         protected ExcelDataValidation(ExcelDataValidation validation,ExcelWorksheet ws)
         {
             Uid = validation.Uid;

src/EPPlus/DataValidation/ExcelDataValidationAny.cs

@@ -25,6 +25,7 @@ public class ExcelDataValidationAny : ExcelDataValidation, IExcelDataValidationA
         /// </summary>
         /// <param name="uid">Uid of the data validation, format should be a Guid surrounded by curly braces.</param>
         /// <param name="address"></param>
+        /// <param name="ws">The worksheet</param>
         internal ExcelDataValidationAny(string uid, string address, ExcelWorksheet ws) : base(uid, address, ws)
         {
         }
@@ -33,6 +34,7 @@ internal ExcelDataValidationAny(string uid, string address, ExcelWorksheet ws) :
         /// Constructor for reading data
         /// </summary>
         /// <param name="xr">The XmlReader to read from</param>
+        /// <param name="ws">The worksheet</param>
         internal ExcelDataValidationAny(XmlReader xr, ExcelWorksheet ws) : base(xr, ws)
         {
         }
@@ -41,6 +43,7 @@ internal ExcelDataValidationAny(XmlReader xr, ExcelWorksheet ws) : base(xr, ws)
         /// Copy constructor
         /// </summary>
         /// <param name="copy"></param>
+        /// <param name="ws">The worksheet</param>
         internal ExcelDataValidationAny(ExcelDataValidationAny copy, ExcelWorksheet ws) : base(copy, ws)
         {
         }

src/EPPlus/DataValidation/ExcelDataValidationCollection.cs

@@ -222,6 +222,7 @@ internal void ValidateAll()
         /// Optionally add address at end for new copy with address in range
         /// </summary>
         /// <param name="dv"></param>
+        /// <param name="added">The worksheet</param>
         /// <param name="address"></param>
         internal void AddCopyOfDataValidation(ExcelDataValidation dv, ExcelWorksheet added, string address = null)
         {

src/EPPlus/DataValidation/ExcelDataValidationCustom.cs

@@ -25,9 +25,9 @@ public class ExcelDataValidationCustom : ExcelDataValidationWithFormula<IExcelDa
         /// <summary>
         /// Constructor
         /// </summary>
-        /// <param name="worksheetName"></param>
         /// <param name="uid">Uid of the data validation, format should be a Guid surrounded by curly braces.</param>
         /// <param name="address"></param>
+        /// <param name="ws">The worksheet</param>
         internal ExcelDataValidationCustom(string uid, string address, ExcelWorksheet ws)
             : base(uid, address, ws)
         {
@@ -47,6 +47,7 @@ internal ExcelDataValidationCustom(XmlReader xr, ExcelWorksheet ws)
         /// Copy constructor
         /// </summary>
         /// <param name="copy"></param>
+        /// <param name="ws">The worksheet</param>
         internal ExcelDataValidationCustom(ExcelDataValidationCustom copy, ExcelWorksheet ws) : base(copy, ws)
         {
             Formula = copy.Formula;

src/EPPlus/DataValidation/ExcelDataValidationDateTime.cs

@@ -26,9 +26,9 @@ public class ExcelDataValidationDateTime : ExcelDataValidationWithFormula2<IExce
         /// <summary>
         /// Constructor
         /// </summary>
-        /// <param name="worksheetName"></param>
         /// <param name="uid">Uid of the data validation, format should be a Guid surrounded by curly braces.</param>
         /// <param name="address"></param>
+        /// <param name="ws">The worksheet</param>
         internal ExcelDataValidationDateTime(string uid, string address, ExcelWorksheet ws)
             : base(uid, address, ws)
         {
@@ -49,6 +49,7 @@ internal ExcelDataValidationDateTime(XmlReader xr, ExcelWorksheet ws)
         /// Copy constructor
         /// </summary>
         /// <param name="copy"></param>
+        /// <param name="ws">The worksheet</param>
         internal ExcelDataValidationDateTime(ExcelDataValidationDateTime copy, ExcelWorksheet ws) : base(copy, ws)
         {
             Formula = copy.Formula;

src/EPPlus/DataValidation/ExcelDataValidationDecimal.cs

@@ -25,9 +25,9 @@ public class ExcelDataValidationDecimal : ExcelDataValidationWithFormula2<IExcel
         /// <summary>
         /// Constructor
         /// </summary>
-        /// <param name="worksheetName"></param>
         /// <param name="uid">Uid of the data validation, format should be a Guid surrounded by curly braces.</param>
         /// <param name="address"></param>
+        /// <param name="ws">The worksheet</param>
         internal ExcelDataValidationDecimal(string uid, string address, ExcelWorksheet ws)
             : base(uid, address, ws)
         {
@@ -39,6 +39,7 @@ internal ExcelDataValidationDecimal(string uid, string address, ExcelWorksheet w
         /// Constructor for reading data
         /// </summary>
         /// <param name="xr">The XmlReader to read from</param>
+        /// <param name="ws">The worksheet</param>
         internal ExcelDataValidationDecimal(XmlReader xr, ExcelWorksheet ws)
             : base(xr, ws)
         {
@@ -48,6 +49,7 @@ internal ExcelDataValidationDecimal(XmlReader xr, ExcelWorksheet ws)
         /// Copy constructor
         /// </summary>
         /// <param name="copy"></param>
+        /// <param name="ws">The worksheet</param>
         internal ExcelDataValidationDecimal(ExcelDataValidationDecimal copy, ExcelWorksheet ws) : base(copy, ws)
         {
             Formula = copy.Formula;

src/EPPlus/DataValidation/ExcelDataValidationInt.cs

@@ -27,6 +27,7 @@ public class ExcelDataValidationInt : ExcelDataValidationWithFormula2<IExcelData
         /// Constructor for reading data
         /// </summary>
         /// <param name="xr">The XmlReader to read from</param>
+        /// <param name="ws">Worksheet</param>
         ///  <param name="isTextLength">Bool to define type of int validation</param>
         internal ExcelDataValidationInt(XmlReader xr, ExcelWorksheet ws, bool isTextLength = false)
             : base(xr, ws)
@@ -37,9 +38,9 @@ internal ExcelDataValidationInt(XmlReader xr, ExcelWorksheet ws, bool isTextLeng
         /// <summary>
         /// Constructor
         /// </summary>
-        /// <param name="worksheetName"></param>
         /// <param name="uid">Uid of the data validation, format should be a Guid surrounded by curly braces.</param>
         /// <param name="address"></param>
+        /// <param name="ws">The worksheet</param>
         /// <param name="isTextLength">Bool to define type of int validation</param>
         internal ExcelDataValidationInt(string uid, string address, ExcelWorksheet ws, bool isTextLength = false)
             : base(uid, address, ws)
@@ -54,6 +55,7 @@ internal ExcelDataValidationInt(string uid, string address, ExcelWorksheet ws, b
         /// Copy constructor
         /// </summary>
         /// <param name="copy"></param>
+        /// <param name="ws">The worksheet</param>
         internal ExcelDataValidationInt(ExcelDataValidationInt copy, ExcelWorksheet ws) 
             : base(copy, ws)
         {

src/EPPlus/DataValidation/ExcelDataValidationList.cs

@@ -27,10 +27,9 @@ public class ExcelDataValidationList : ExcelDataValidationWithFormula<IExcelData
         /// <summary>
         /// Constructor
         /// </summary>
-        /// <param name="worksheet"></param>
         /// <param name="uid">Uid of the data validation, format should be a Guid surrounded by curly braces.</param>
         /// <param name="address"></param>
-        /// <param name="validationType"></param>
+        /// <param name="ws">The worksheet</param>
         internal ExcelDataValidationList(string uid, string address, ExcelWorksheet ws)
             : base(uid, address, ws)
         {

src/EPPlus/DataValidation/ExcelDataValidationTime.cs

@@ -25,10 +25,9 @@ public class ExcelDataValidationTime : ExcelDataValidationWithFormula2<IExcelDat
         /// <summary>
         /// Constructor
         /// </summary>
-        /// <param name="worksheet"></param>
         /// <param name="uid">Uid of the data validation, format should be a Guid surrounded by curly braces.</param>
         /// <param name="address"></param>
-        /// <param name="validationType"></param>
+        /// <param name="ws">The worksheet</param>
         internal ExcelDataValidationTime(string uid, string address, ExcelWorksheet ws)
             : base(uid, address, ws)
         {
@@ -40,6 +39,7 @@ internal ExcelDataValidationTime(string uid, string address, ExcelWorksheet ws)
         /// Constructor for reading data
         /// </summary>
         /// <param name="xr">The XmlReader to read from</param>
+        /// <param name="ws">The worksheet</param>
         internal ExcelDataValidationTime(XmlReader xr, ExcelWorksheet ws)
             : base(xr, ws)
         {
@@ -49,6 +49,7 @@ internal ExcelDataValidationTime(XmlReader xr, ExcelWorksheet ws)
         /// Copy constructor
         /// </summary>
         /// <param name="copy"></param>
+        /// <param name="ws"></param>
         internal ExcelDataValidationTime(ExcelDataValidationTime copy, ExcelWorksheet ws) 
             : base(copy, ws)
         {

src/EPPlus/DataValidation/ExcelDataValidationType.cs

@@ -82,8 +82,7 @@ public class ExcelDataValidationType
         /// <summary>
         /// Returns a validation type by <see cref="eDataValidationType"/>
         /// </summary>
-        /// <param name="type"></param>
-        /// <returns></returns>
+        /// <returns>The string output</returns>
         internal string TypeToXmlString()
         {
             switch (Type)

src/EPPlus/DataValidation/ExcelDataValidationWithFormula.cs

@@ -32,9 +32,9 @@ public abstract class ExcelDataValidationWithFormula<T> : ExcelDataValidation
         /// <summary>
         /// Constructor
         /// </summary>
-        /// <param name="workSheetName"></param>
         /// <param name="uid">Uid of the data validation, format should be a Guid surrounded by curly braces.</param>
         /// <param name="address"></param>
+        /// <param name="ws">The worksheet</param>
         internal ExcelDataValidationWithFormula(string uid, string address, ExcelWorksheet ws)
             : base(uid, address, ws)
         {
@@ -45,6 +45,7 @@ internal ExcelDataValidationWithFormula(string uid, string address, ExcelWorkshe
         /// Constructor for reading data
         /// </summary>
         /// <param name="xr">The XmlReader to read from</param>
+        /// <param name="ws">The worksheet</param>
         internal ExcelDataValidationWithFormula(XmlReader xr, ExcelWorksheet ws)
             : base(xr, ws)
         {
@@ -54,6 +55,7 @@ internal ExcelDataValidationWithFormula(XmlReader xr, ExcelWorksheet ws)
         /// Copy Constructor
         /// </summary>
         /// <param name="copy"></param>
+        /// <param name="ws">The worksheet</param>
         internal ExcelDataValidationWithFormula(ExcelDataValidation copy, ExcelWorksheet ws)
             : base(copy, ws)
         {
@@ -62,7 +64,7 @@ internal ExcelDataValidationWithFormula(ExcelDataValidation copy, ExcelWorksheet
         internal override void ReadClassSpecificXmlNodes(XmlReader xr)
         {
             base.ReadClassSpecificXmlNodes(xr);
-            Formula = ReadFormula(xr, "formula1");
+            Formula = ReadFormula(xr, "formula");
         }
 
         internal T ReadFormula(XmlReader xr, string formulaIdentifier)

src/EPPlus/DataValidation/ExcelDataValidationWithFormula2.cs

@@ -26,9 +26,9 @@ public abstract class ExcelDataValidationWithFormula2<T> : ExcelDataValidationWi
         /// <summary>
         /// Constructor
         /// </summary>
-        /// <param name="workSheetName"></param>
         /// <param name="uid">Uid of the data validation, format should be a Guid surrounded by curly braces.</param>
         /// <param name="address"></param>
+        /// <param name="ws">The worksheet</param>
         internal ExcelDataValidationWithFormula2(string uid, string address, ExcelWorksheet ws)
             : base(uid, address, ws)
         {

src/EPPlus/DataValidation/Formulas/ExcelDataValidationFormula.cs

@@ -41,15 +41,14 @@ internal enum FormulaState
     /// </summary>
     internal abstract class ExcelDataValidationFormula :IExcelDataValidationFormula
     {
-
-        internal event System.EventHandler BecomesExt;
-
         private readonly Action<OnFormulaChangedEventArgs> _handler;
 
         /// <summary>
         /// Constructor
         /// </summary>
         /// <param name="validationUid">id of the data validation containing this formula</param>
+        /// <param name="workSheetName">The worksheet name</param>
+        /// <param name="extListHandler">A callback when the formula is changed.</param>
         public ExcelDataValidationFormula(string validationUid, string workSheetName, Action<OnFormulaChangedEventArgs> extListHandler)
         {
             Require.Argument(validationUid).IsNotNullOrEmpty("validationUid");

src/EPPlus/DataValidation/Formulas/ExcelDataValidationFormulaValue.cs

@@ -26,6 +26,8 @@ internal abstract class ExcelDataValidationFormulaValue<T> : ExcelDataValidation
         /// Constructor
         /// </summary>
         /// <param name="validationUid">Uid for the data validation</param>
+        /// <param name="worksheetName">The worksheet name</param>
+        /// <param name="extListHandler">Callback for updateing formulas</param>
         public ExcelDataValidationFormulaValue(string validationUid, string worksheetName, Action<OnFormulaChangedEventArgs> extListHandler)
             : base(validationUid, worksheetName, extListHandler)
         {

src/EPPlus/Drawing/Chart/ExcelChartAxisStandard.cs

@@ -635,7 +635,7 @@ internal override eAxisType AxisType
         /// <summary>
         /// Adds the axis title and styles it according to the style selected in the StyleManager
         /// </summary>
-        /// <param name="title"></param>
+        /// <param name="linkedCell">A cell range to link the title to.</param>
         public void AddTitle(ExcelRangeBase linkedCell)
         {
             Title.LinkedCell = linkedCell;

src/EPPlus/ExcelPackage.cs

@@ -531,6 +531,10 @@ private void ConstructNewFile(string password)
                 }
                 catch (Exception ex)
                 {
+                    if (ms != null)
+                    {
+                        ms.Dispose();
+                    }
                     if (password == null && CompoundDocument.IsCompoundDocument(File))
                     {
                         throw new Exception("Cannot open the package. The package is an OLE compound document. If this is an encrypted package, please supply the password", ex);
@@ -539,10 +543,6 @@ private void ConstructNewFile(string password)
                     {
                         throw;
                     }
-                    if(ms!=null)
-                    {
-                        ms.Dispose();
-                    }
                 }
             }
             else

src/EPPlus/ExcelRangeBase.cs

@@ -34,7 +34,6 @@ Date               Author                       Change
 using OfficeOpenXml.ConditionalFormatting;
 using OfficeOpenXml.ConditionalFormatting.Contracts;
 using OfficeOpenXml.FormulaParsing.LexicalAnalysis;
-using w = System.Windows;
 using OfficeOpenXml.Utils;
 using OfficeOpenXml.Compatibility;
 using OfficeOpenXml.Core;

src/EPPlus/ExcelStyles.cs

@@ -14,8 +14,6 @@ Date               Author                       Change
 using System.Xml;
 using System.Linq;
 using System.Collections.Generic;
-using OfficeOpenXml.FormulaParsing.Excel.Functions.Logical;
-using draw=System.Drawing;
 using OfficeOpenXml.Style;
 using OfficeOpenXml.Style.XmlAccess;
 using OfficeOpenXml.Style.Dxf;

src/EPPlus/FormulaParsing/Excel/Functions/DoubleArgumentParser.cs

@@ -18,7 +18,7 @@ Date               Author                       Change
 using OfficeOpenXml.FormulaParsing;
 using OfficeOpenXml.FormulaParsing.Utilities;
 using OfficeOpenXml.FormulaParsing.Exceptions;
-using util=OfficeOpenXml.Utils;
+using Util=OfficeOpenXml.Utils;
 
 namespace OfficeOpenXml.FormulaParsing.Excel.Functions
 {
@@ -33,7 +33,7 @@ public override object Parse(object obj)
                 return r == null ? 0 : r.ValueDouble;
             }
             if (obj is double) return obj;
-            if (obj.IsNumeric()) return util.ConvertUtil.GetValueDouble(obj);
+            if (obj.IsNumeric()) return Util.ConvertUtil.GetValueDouble(obj);
             var str = obj != null ? obj.ToString() : string.Empty;
             try
             {

src/EPPlus/FormulaParsing/Excel/Functions/Finance/Implementations/XirrImpl.cs

@@ -17,10 +17,10 @@ Date               Author                       Change
 
 namespace OfficeOpenXml.FormulaParsing.Excel.Functions.Finance.Implementations
 {
-    public static class XirrImpl
+    internal static class XirrImpl
     {
 
-        public static FinanceCalcResult<double> GetXirr(IEnumerable<double> aValues, IEnumerable<System.DateTime> aDates, double rGuessRate = 0.1)
+        internal static FinanceCalcResult<double> GetXirr(IEnumerable<double> aValues, IEnumerable<System.DateTime> aDates, double rGuessRate = 0.1)
         {
             if (aValues.Count() != aDates.Count()) return new FinanceCalcResult<double>(eErrorType.Value);