Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image sizes broken #1626

Closed
paviad opened this issue Oct 14, 2024 · 2 comments · Fixed by #1636
Closed

Image sizes broken #1626

paviad opened this issue Oct 14, 2024 · 2 comments · Fixed by #1636
Assignees
Labels
bug Something isn't working

Comments

@paviad
Copy link

paviad commented Oct 14, 2024

EPPlus usage

Personal use

Environment

Windows

Epplus version

7.4.1

Spreadsheet application

Excel

Description

When creating a new file based on a template, the images in the output are different than those in the template.

This bug applies to versions 7.4.0 and 7.4.1 (in version 7.3.2 it works fine)

This is a screenshot of the template:

image

This is a screenshot of the bad output:

image

See my repo at https://github.com/paviad/eeplus-bug for a minimal repro.

@paviad paviad added the bug Something isn't working label Oct 14, 2024
@paviad
Copy link
Author

paviad commented Oct 14, 2024

git bisect indicates that this is the first bad commit 02ca050

@OssianEPPlus OssianEPPlus self-assigned this Oct 15, 2024
OssianEPPlus added a commit that referenced this issue Oct 15, 2024
@OssianEPPlus
Copy link
Contributor

Thanks for reporting! This is a bug introduced with some changes related to image handling to introduce linked pictures. Essentially for some re-calculations we need to load the image at 100% original size, this was intended to be temporary/internal but a bug has been introduced in the handling.
We are working on a fix.

@OssianEPPlus OssianEPPlus linked a pull request Oct 17, 2024 that will close this issue
JanKallman pushed a commit that referenced this issue Oct 21, 2024
* Added fix for #1626

* Ensured two-anchor and other images are copied properly

* Added fixed issues
JanKallman added a commit that referenced this issue Nov 18, 2024
* Delete method for ole objects.

* Update Microsoft.Extensions.Configuration.Json to 8.0.1 - #1623

* Feature/new default font (#1621)

* Tests for new default font

* wip

* Added scale factors for Aptos Display and Aptos Narrow

* Updated test project file

* Removed invalid test

---------

Co-authored-by: swmal <897655+swmal@users.noreply.github.com>

* EPPlus version 7.4.1

* Removed fixed references

* Added version information in history list

* Copy ole object and tests

* #1624 - fix for preserving rich data on save (#1625)

* #1624 - fix for preserving rich data on save

* Removed uncommented code

---------

Co-authored-by: swmal <{ID}+username}@users.noreply.github.com>

* Fixed some issues with copy ole object.

* Copy ole object complete.

* Fixed issue with opening ms office documents.

* Fixed issue opening copes of ms office docs.

* Uisng Picture store for ole emf images

* Copying ole objects through worksheet copy

* ole worksheet copy progress

* Bug/i1626 (#1636)

* Added fix for #1626

* Ensured two-anchor and other images are copied properly

* Added fixed issues

* Added minor feature for #1632 (#1637)

* Bug/s745 (#1644)

* Located one problem area

* Added comparisons and fixed incorrect flags

* Added fixed issues

* Fixed some issues with linked ole objects and finished worksheet copy.

* Fixes issue #1645 (#1648)

* Fixes issue #1646 (#1647)

* Added fix for #1628. Corrected ids on deleting tables (#1634)

modified:   EPPlusTest/Issues/LegacyTests/Issues.cs

* Bug/i1631 Row/ColumnOffsets (#1633)

* Fix for #1631 column/row offset in shared formulas

* Added fixed issues note

* add testmethod

* added Ole Object xml comments, stream, fileinfo, name, arg object

* Stream and fileinfo tests.

* Fixes array formula calculation for single cells containing range operations (#1657)

* Fixes array formula calculation for single cell arrays. #1649

* Range operations using conditional operators are now identified as dynamic array formulas

* Replaced ApplyWithDynamicResult method with Apply

* Minor changes to Update of table array property

* Fixed issue #1653 and enabled update of the Workbook.MaxFontWidth property. (#1654)

* EPPlus version 7.4.2

* Many small changes.

* Fixed some tests

* moved Emf check

* Fixed errors and fixed correct TextMetrics

---------

Co-authored-by: JanKallman <jan.kallman@epplussoftware.com>
Co-authored-by: swmal <897655+swmal@users.noreply.github.com>
Co-authored-by: swmal <{ID}+username}@users.noreply.github.com>
Co-authored-by: OssianEPPlus <122265629+OssianEPPlus@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants