Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1092 - fixed filtering of member attributes in LoadFromCollection #1093

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

swmal
Copy link
Contributor

@swmal swmal commented Oct 9, 2023

See #1092.

This fix contains a small behaviour change:

Previously when using the ExcelNestedTableColumn attribute on a property of a complex class all members of the nested class was included. Now only attributes specified in the members list (LoadFromCollection argument) will be included for the 1st level. For nested (complex) classes on properties configuration from attributes will be used.

@swmal swmal requested a review from JanKallman October 9, 2023 10:29
@swmal swmal self-assigned this Oct 9, 2023
@swmal swmal added the bug Something isn't working label Oct 9, 2023
@JanKallman JanKallman merged commit 656d197 into develop Oct 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants