[Cleanup] Use a constant reference for content_flags in SetContentFla…

…gs() (#3196) # Notes - This is more performant. - https://pvs-studio.com/en/docs/warnings/v813/ - https://pvs-studio.com/en/docs/warnings/v820/
EQEmu · Apr 3, 2023 · 6976e27 · 6976e27
1 parent c9f27d6
commit 6976e27
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/common/content/world_content_service.cpp b/common/content/world_content_service.cpp
@@ -120,7 +120,7 @@ std::vector<std::string> WorldContentService::GetContentFlagsDisabled()
 /**
  * @param content_flags
  */
-void WorldContentService::SetContentFlags(std::vector<ContentFlagsRepository::ContentFlags> content_flags)
+void WorldContentService::SetContentFlags(const std::vector<ContentFlagsRepository::ContentFlags>& content_flags)
 {
 	WorldContentService::content_flags = content_flags;
 }

diff --git a/common/content/world_content_service.h b/common/content/world_content_service.h
@@ -167,7 +167,7 @@ class WorldContentService {
 	std::vector<std::string> GetContentFlagsDisabled();
 	bool IsContentFlagEnabled(const std::string& content_flag);
 	bool IsContentFlagDisabled(const std::string& content_flag);
-	void SetContentFlags(std::vector<ContentFlagsRepository::ContentFlags> content_flags);
+	void SetContentFlags(const std::vector<ContentFlagsRepository::ContentFlags>& content_flags);
 	void ReloadContentFlags();
 	WorldContentService * SetExpansionContext();