[Bug Fix] Preserve Permanent pet buffs across zone transitions #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…buffs to maintain them through zone transitions
|
Can you provide a list of spells that this is needed for? |
There aren't any in PEQ or live-like content. Honestly I don't know of anything in PEQ or live-like content which uses buffdurationformula 50, pet or no. That said, -1 is a valid buff duration, while 0 is not. The methods that account for saving and loading pet buffs cannot account for -1 as a valid buff duration without this change. |
|
This is less of a bug and more of an optional feature if server admins want it |
Akkadius
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.