[Feature] Change mana_used to int32, This will allow higher mana costs to function correctly #2321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to match int32 mana_cost This will allow higher mana costs to function
|
Line 357 in 20c639c Can you nuke this line? It doesn't appear to be called, otherwise I'd ask you to update it. |
|
@mackal Done. |
mackal
approved these changes
Jul 21, 2022
…ses function is Int32)
mackal
suggested changes
Jul 22, 2022
Sorry, I meant to commit those changes to a new PR, how do I go about fixing? |
|
mackal
approved these changes
Jul 27, 2022
Kinglykrab
changed the title
Kinglykrab
approved these changes
Jul 30, 2022
mackal
pushed a commit
that referenced
this pull request
Sep 3, 2022
* Changed mana_used to use int32, to match int32 mana_cost This will allow higher mana costs to function * Corrected DoHPToManaCovert to Int32 * Removed unused uint16 GetMana function call from Server/zone/questmgr.h * Change GetSkillDmgAmt from Int16 to Int32 (SkillDamageAmount2 which uses function is Int32) * Delete mob.cpp * Revert "Delete mob.cpp" This reverts commit 3db8bf0. * Revert "Change GetSkillDmgAmt from Int16 to Int32 (SkillDamageAmount2 which uses function is Int32)" This reverts commit cf5dbc9. Co-authored-by: dmcintosh-BCT <dan@blackcreektechnologies.com>
catapultam-habeo
pushed a commit
to catapultam-habeo/pyrelight-server
that referenced
this pull request
Mar 27, 2023
* Changed mana_used to use int32, to match int32 mana_cost This will allow higher mana costs to function * Corrected DoHPToManaCovert to Int32 * Removed unused uint16 GetMana function call from Server/zone/questmgr.h * Change GetSkillDmgAmt from Int16 to Int32 (SkillDamageAmount2 which uses function is Int32) * Delete mob.cpp * Revert "Delete mob.cpp" This reverts commit 3db8bf0. * Revert "Change GetSkillDmgAmt from Int16 to Int32 (SkillDamageAmount2 which uses function is Int32)" This reverts commit cf5dbc9. Co-authored-by: dmcintosh-BCT <dan@blackcreektechnologies.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mana_cost already uses Int32
mana_used is already Int32 under other functions - CastSpell