Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Resolve XP Calculation Bug introduced w/ recent Rule addition #2703

Conversation

Valorith
Copy link
Contributor

@Valorith Valorith commented Jan 3, 2023

Resolves an experience calculation bug introduced by: #2667 and reported by Aiden in discord: https://discord.com/channels/212663220849213441/1059233181498359888

@Valorith Valorith marked this pull request as ready for review January 3, 2023 04:37
@Valorith
Copy link
Contributor Author

Valorith commented Jan 5, 2023

For clarity on this. I didn't fundamentally change the Xp formula with this fix. I primarily just cleaned up the logic to be more clear and fix a logic order flaw or two. I have tested this change and it is working as expected.

Copy link
Contributor

@Kinglykrab Kinglykrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@Aeadoin Aeadoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Aeadoin Aeadoin merged commit ebf69e9 into EQEmu:master Jan 7, 2023
@Valorith Valorith deleted the Bug-Fix]-Resolved-XP-Calculation-error-from-recent-Rule-Addition branch January 8, 2023 05:18
catapultam-habeo pushed a commit to catapultam-habeo/pyrelight-server that referenced this pull request Mar 27, 2023
…on (EQEmu#2703)

* [Bug Fix] Resolve XP Calculation Bug introduced w/ recent Rule addition

* Camel case.

Co-authored-by: Kinglykrab <kinglykrab@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants