[Bug Fix] Fix for undefined MySQL library behavior. #2834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gonna change some things up to get rid of the double connection, have to rewrite a bit of db core. Don't merge yet. |
Kinglykrab
changed the title
|
A few changes, have to test make sure they work. Also I noticed we're not sharing the mutex that protects the connection pointer so have to think up a solution for that. (Sorry it's not all at once I'm doing this as I have time at night) |
…e copy and replaces it with another connection
Akkadius
force-pushed
the
bug-fix-undefined-behavior-mysql-copy
branch
from
c1cf998
to
861b688
Compare
|
Synced up with KLS We agreed that a mutex should be shared across the database instances because they share the same underlying connection. This protects from concurrency / thread-safety issues. Reproduced Problem
Fixed, Running for several minutes 2023-02-24_17-23-39.mp4 |
Akkadius
approved these changes
Feb 25, 2023
|
Tested booting up all servers, logging in game, everything works as expected |
Merged
catapultam-habeo
pushed a commit
to catapultam-habeo/pyrelight-server
that referenced
this pull request
Mar 27, 2023
* MYSQL objects cannot be copied in a well defined way, this removes the copy and replaces it with another connection * Change to share underlying pointers. * Push up mutex changes * Post rebase * Formatting --------- Co-authored-by: KimLS <KimLS@peqtgc.com> Co-authored-by: Akkadius <akkadius1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MYSQL structure in the MySQL C api is not copy aware. This isn't enforced because, well, C doesn't enforce anything really.
See: MySQL Structures
This changes the copy of an existing connection to instead create a second backup connection with the same data as what is being copied. This does introduce another connection into the mix which are a limited resource but given the potential seriousness of the bug in question it seems like a fair tradeoff for now.
Long term we can rewrite the dbcore class to use a underlying pointer instead of a pinned in place variable.