[Strings] Add more number formatters

[Kinglykrab]

Notes

• Adds Strings::ToUnsignedInt for uint32 support.
• Adds Strings::ToBigInt for int64 support.
• Adds Strings::ToUnsignedBigInt for uint64 support.
• Adds Strings::ToFloat for float support.
• Replaces all std::stoi references with Strings::ToInt.
• Replaces all atoi references with Strings::ToInt.
• Replaces all std::stoul references with Strings::ToUnsignedInt.
• Replaces all atoul references with Strings::ToUnsignedInt.
• Replaces all std::stoll references with Strings::ToBigInt.
• Replaces all atoll references with Strings::ToBigInt.
• Replaces all std::stoull references with Strings::ToUnsignedBigInt.
• Replaces all atoull references with Strings::ToUnsignedBigInt.
• Replaces all std::stof references with Strings::ToFloat.

[Akkadius]

Looks great, clean.

Gonna need a rebase and we should at least do some respectable surface level testing

[Akkadius]

I'll take a look at this one later

[Akkadius]

Looked through this all, fairly straightforward.

Have you tested?

I would like to test it and we should probably get at least one other person to also look at it since this is a large surface area

[Kinglykrab]

Looked through this all, fairly straightforward.

Have you tested?

I would like to test it and we should probably get at least one other person to also look at it since this is a large surface area

Yeah, I tested, logged in, ran around, bought items, casted spells, just random stuff since it touches quite a large base.

[Aeadoin]

Looks good to me as well.

[Aeadoin]

I did some testing this this as well, I'm around this weekend if we merge and there's issues (don't think there will be, but this does cover a large scope)

[Aeadoin]

Going to run some benchmarking on this

[Aeadoin]

Initial Benchmarking Tests:

Compilation Mode: Debug

String Value of "1111753784"

Bencmarking Test 2

Compile Mode: RelwithDebInfo

String Value of "1111753784"

Benchmarking Test 3 - Fixed Float testing (previous tests can be discarded for Floats)

Compile Mode: Debug

Above tests show a very minimal performance impact especially with increase in "correctness"

Try-Catch Block Details - https://stackoverflow.com/questions/16784601/does-try-catch-block-decrease-performance

Will run some additional test cases in addition to these.

[Akkadius]

Worked with @Aeadoin @Kinglykrab

There was concern that try / catch has performance impact implications. This is not a bad call-out, however it entirely depends and this thread does a decent job of explaining https://stackoverflow.com/questions/16784601/does-try-catch-block-decrease-performance

• Removed try / catch for simpler IsNumber IsFloat validation functions
• Removed any non IsNumber variants for use of simply IsNumber
• Added unit tests to cover scenarios for IsNumber IsFloat
• Fixed test suite pipeline to just use stdout instead of dumping to a file (which didn't have anything anyways)
• Added CLI command test:string-benchmark so we can use this benchmark in later testing

PR as is (unoptimized, debug)

PR as is (O1)

Simplifications to IsNumber / IsFloat (O1)

Tests

	void TestIsFloat() {
		TEST_ASSERT_EQUALS(Strings::IsFloat("0.23424523"), true);
		TEST_ASSERT_EQUALS(Strings::IsFloat("12312312313.23424523"), true);
		TEST_ASSERT_EQUALS(Strings::IsFloat("12312312313"), true);
		TEST_ASSERT_EQUALS(Strings::IsFloat(".234234"), true);
		TEST_ASSERT_EQUALS(Strings::IsFloat(".234234f"), false);
		TEST_ASSERT_EQUALS(Strings::IsFloat("Johnson"), false);
	}

	void TestIsNumber() {
		TEST_ASSERT_EQUALS(Strings::IsNumber("0.23424523"), false);
		TEST_ASSERT_EQUALS(Strings::IsNumber("12312312313.23424523"), false);
		TEST_ASSERT_EQUALS(Strings::IsNumber("12312312313"), true);
		TEST_ASSERT_EQUALS(Strings::IsNumber("12312312313f"), false); // character at end
		TEST_ASSERT_EQUALS(Strings::IsNumber("18446744073709551616"), true); // 64
		TEST_ASSERT_EQUALS(Strings::IsNumber("-18"), true);
		TEST_ASSERT_EQUALS(Strings::IsNumber("-f18"), false);
		TEST_ASSERT_EQUALS(Strings::IsNumber("-18446744073709551616"), true); // 64
	}

Test Results

eqemu@15bfea186d05:~/server$ server && ~/code/build/bin/tests
Import |    Info    | LoadPaths server [/home/eqemu/server] 
Import |    Info    | LoadPaths logs path [logs] 
Import |    Info    | LoadPaths lua mods path [] 
Import |    Info    | LoadPaths lua_modules path [quests/lua_modules] 
Import |    Info    | LoadPaths maps path [maps] 
Import |    Info    | LoadPaths patches path [assets/patches] 
Import |    Info    | LoadPaths plugins path [quests/plugins] 
Import |    Info    | LoadPaths quests path [quests] 
Import |    Info    | LoadPaths shared_memory path [shared] 
MemoryMappedFileTest: 2/2, 100% correct in 0.000000 seconds
IPCMutexTest: 4/4, 100% correct in 0.000000 seconds
FixedMemoryHashTest: 12/12, 100% correct in 0.000000 seconds
FixedMemoryVariableHashTest: 8/8, 100% correct in 0.000000 seconds
atoboolTest: 13/13, 100% correct in 0.000000 seconds
hextoi_32_64_Test: 12/12, 100% correct in 0.000000 seconds
StringUtilTest: 7/7, 100% correct in 0.000000 seconds
DataVerificationTest: 4/4, 100% correct in 0.000000 seconds
SkillsUtilsTest: 2/2, 100% correct in 0.000000 seconds
TaskStateTest: 16/16, 100% correct in 0.000000 seconds
Total: 80 tests, 100% correct in 0.000000 seconds