[Bots] Verify Group Integrity during Bot::AddBotToGroup #2980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kinglykrab
approved these changes
Feb 22, 2023
Akkadius
approved these changes
Feb 23, 2023
Merged
catapultam-habeo
pushed a commit
to catapultam-habeo/pyrelight-server
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: This PR aims to ensure the Bots Group is in a valid state when being joined. these checks are already being performed on Bot::LoadAndSpawnAllZonedBots, but not all scenarios are covered such as Bot group autospawn functionality, and regular invites.
Why:
Numerous crashes are being seen caused likely by dangling Group member pointers. This can be seen in the following crashes where we check if the pointer is nullptr, pointer is not null, and yet we still crash when trying to call a member function:
http://spire.akkadius.com/dev/release/22.4.2?id=691
http://spire.akkadius.com/dev/release/22.4.2?id=690
http://spire.akkadius.com/dev/release/22.4.2?id=709