Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bots] Cleanup BotDatabase::LoadBuffs #2981

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Conversation

Aeadoin
Copy link
Contributor

@Aeadoin Aeadoin commented Feb 23, 2023

Added Checks to initialize all buff slots (mimics Client LoadBuffs method)
Cleaned up all atoi conversions, change to Strings::ToInt and atoul where applicable.

zone/bot_database.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@Kinglykrab Kinglykrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be worth converting this to load the data from repositories. Not now, but in the future.

zone/bot_database.cpp Outdated Show resolved Hide resolved
@Aeadoin Aeadoin merged commit 5acc181 into EQEmu:master Feb 24, 2023
@Aeadoin Aeadoin deleted the cleanuploadbuffs branch February 24, 2023 17:58
@Akkadius Akkadius mentioned this pull request Feb 25, 2023
catapultam-habeo pushed a commit to catapultam-habeo/pyrelight-server that referenced this pull request Mar 27, 2023
* [Bots] Cleanup BotDatabae::LoadBuffs

* cleanup formatting/syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants