Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Fix possible overflows in Client::AddPlatinum() and Client::TakePlatinum() #3255

Merged
merged 1 commit into from
Apr 5, 2023
Merged

[Cleanup] Fix possible overflows in Client::AddPlatinum() and Client::TakePlatinum() #3255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions zone/client.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2222,7 +2222,7 @@ uint32 Client::GetCarriedPlatinum() {

bool Client::TakePlatinum(uint32 platinum, bool update_client) {
if (GetCarriedPlatinum() >= platinum) {
auto copper = static_cast<uint64>(platinum * 1000);
const auto copper = static_cast<uint64>(platinum) * 1000;
return TakeMoneyFromPP(copper, update_client);
}

Expand Down Expand Up @@ -2316,7 +2316,7 @@ bool Client::TakeMoneyFromPP(uint64 copper, bool update_client) {
}

void Client::AddPlatinum(uint32 platinum, bool update_client) {
auto copper = static_cast<uint64>(platinum * 1000);
const auto copper = static_cast<uint64>(platinum) * 1000;
AddMoneyToPP(copper, update_client);
}

Expand Down