Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Commands] Assign #opcode to a #reload alias #3401

Merged
merged 2 commits into from
Jun 12, 2023
Merged

[Commands] Assign #opcode to a #reload alias #3401

merged 2 commits into from
Jun 12, 2023

Conversation

Kinglykrab
Copy link
Contributor

@Kinglykrab Kinglykrab commented Jun 10, 2023 •
edited
Loading

Notes

  • Can use #reload opcodes or #opcode to reload opcodes now instead of it being its own command file.

@Kinglykrab
[Commands] Assign #opcode to a #reload alias
5de9560 
# Notes
- Can use `#reload opcodes
Akkadius
Akkadius approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@Akkadius Akkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's get this hooked into the reload API as well

world/eqemu_api_world_data_service.cpp:137 add just add a Reload struct entry - should just work as long as we have world handlers for it

@Kinglykrab Kinglykrab merged commit 18eff72 into master Jun 12, 2023
@Kinglykrab Kinglykrab deleted the commands/opcode_reload_alias branch June 12, 2023 22:42
@Kinglykrab Kinglykrab mentioned this pull request Jun 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akkadius Akkadius Akkadius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kinglykrab @Akkadius