Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quest API] Adjust GetCloseMobList calls internally #3530

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

Akkadius
Copy link
Member

@Akkadius Akkadius commented Aug 3, 2023

This PR does a few minor but performance impacting changes

  • We shouldn't reserve on the container when we don't know for certain whether or not we end up filtering ourself in the list, we end up returning blank values to the user in the Quest API results. You can double loop but the juice is not worth the squeeze performance wise - I measured this very recently.
  • Also - we are even further filtering based on the distance passed in by the user which further filters down the close list that is compiled from 600 units

@Akkadius Akkadius merged commit 8fce86c into master Aug 4, 2023
@Akkadius Akkadius deleted the akkadius/adjust-scan-quest-apis branch August 4, 2023 18:05
@Akkadius Akkadius mentioned this pull request Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants