[Feature] Corpse Overhaul

[fryguy503]

Corpse Overhaul

Changelog:

• Player corpses now have two timers, one specific to the rezability of the corpse and the other to cover the overall rot timer of the player corpse.
• The rezability timer is based on the online presence of the player/account and is not affected by being offline.
• The rot timer is not affected by offline/online status and will count to the rot status of the corpse.
• Corpses can be rezzed multiple times, however only the first rez that yeilds returned xp will be counted. Not other rez will return any xp. This allows for a "Poor mans COTH" as was used many times in the early eras.
• All Corpse class private/protected member variables are all now prefixed with m_
• Added Corpses logging category along with many debug logs
• Removed LoadCharacterCorpseData
• Removed LoadCharacterCorpseEntity
• Added LoadCharacterCorpse(const CharacterCorpsesRepository::CharacterCorpses, const glm::vec4 &position) which simplifies areas of consumption and reduces double queries from removing LoadCharacterCorpseData and replacing LoadCharacterCorpseEntity
• All parameters that were prefixed with in_ have been dropped
• Removed two queries from CheckIsOwnerOnline and have it query the world's CLE by account_id since that is how live works
• Regenerated repository character_corpses
• Cleaned up many list iterators to use range based for loops
• Rate limit Corpse::Process m_is_rezzable with a 1 second check timer
• General code cleanup
• Added a Server Up check to bury all corpses in instances to prevent lost corpses if an instance is released during server down. This facilitates player recovery via shadowrest or priests of luclin.

This PR also now fixes a long standing issue with HasItem performance in our script plugins. It is significantly faster, we will need to coordinate quest changes and comms with operators.

    if ($client->HasItemOnCorpse($item_id)) {
        return 1;
    }

    --corpse
    if self:HasItemOnCorpse(itemid) then
        return true
    end

Testing Completed:

• Create a Corpse
• Standard rezzing
• Ghetto Coth (No Extra XP)
• Rezzing after graveyard move
• Divine Rez works as intended
• No XP Rez (Corpse Call) does not give XP
• Corpse Burying
• Cross Instance Graveyard Corpse movement/Rezzing
• DZ End/Quit Corpse Movement/Rezzing
• Server Shutdown/Reinit DZ Corpse Movement/Rezzing

[Akkadius]

This PR also now fixes a long standing issue with HasItem performance in our script plugins. It is significantly faster, we will need to coordinate quest changes and comms with operators.

    if ($client->HasItemOnCorpse($item_id)) {
        return 1;
    }

    --corpse
    if self:HasItemOnCorpse(itemid) then
        return true
    end

Changelog

• All Corpse class private/protected member variables are all now prefixed with m_
• Added Corpses logging category along with many debug logs
• Removed LoadCharacterCorpseData
• Removed LoadCharacterCorpseEntity
• Added LoadCharacterCorpse(const CharacterCorpsesRepository::CharacterCorpses, const glm::vec4 &position) which simplifies areas of consumption and reduces double queries from removing LoadCharacterCorpseData and replacing LoadCharacterCorpseEntity
• All parameters that were prefixed with in_ have been dropped
• Removed two queries from CheckIsOwnerOnline and have it query the world's CLE by account_id since that is how live works
• Regenerated repository character_corpses
• Cleaned up many list iterators to use range based for loops
• Rate limit Corpse::Process m_is_rezzable with a 1 second check timer
• General code cleanup

[fryguy503]

I have verified the following:

• Create a Corpse
• Standard rezzing
• Ghetto Coth (No Extra XP)
• Rezzing after graveyard move
• Divine Rez works as intended
• No XP Rez (Corpse Call) does not give XP
• Corpse Burying
• Cross Instance Graveyard Corpse movement/Rezzing
• DZ End/Quit Corpse Movement/Rezzing
• Server Shutdown/Reinit DZ Corpse Movement/Rezzing

Added a Server Up check to bury all corpses in instances to prevent lost corpses if an instance is released during server down. This facilitates player recovery via shadowrest or priests of luclin.