Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup] Cleanup Account Status Code #4376

Merged
merged 3 commits into from
Jun 2, 2024
Merged

[Cleanup] Cleanup Account Status Code #4376

merged 3 commits into from
Jun 2, 2024

Conversation

Kinglykrab
Copy link
Contributor

Description

  • Introduces a AccountStatus namespace for object types instead of an enum like we had before.

Type of Change

  • New feature

Testing

image

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@Kinglykrab Kinglykrab force-pushed the cleanup/account_status_cude branch from 332b2f6 to e932446 Compare June 2, 2024 08:28
@Kinglykrab Kinglykrab merged commit 7a648cc into master Jun 2, 2024
2 checks passed
@Kinglykrab Kinglykrab deleted the cleanup/account_status_cude branch June 2, 2024 20:40
@Akkadius Akkadius mentioned this pull request Jun 14, 2024
Merged
catapultam-habeo pushed a commit to The-Heroes-Journey-EQEMU/Server that referenced this pull request Jul 14, 2024
@Kinglykrab @catapultam-habeo
[Cleanup] Cleanup Account Status Code (EQEmu#4376)
c0a8b61 
* [Cleanup] Cleanup Account Status Code

* Update emu_constants.cpp

* Update emu_constants.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akkadius Akkadius Akkadius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kinglykrab @Akkadius