[Bug Fix] Slay Adjustments #4389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous change did not account for the modern slay undead and holyforge spells. Reverted some of the changes and cleaned up others. Rule Renamed (Default value was incorrect, this was a clean way to fix that) - SlayDamageAdjustment -> SlayDamageMultiplier Also added a rate multiplier RULE_REAL(Combat, SlayRateMultiplier, 1.0, "Slay Rate Adjustments - Multiply final slay rate check by this value. Default: 1.0") Fixed the ordering of the constants for the slay undead SPA that were backwards and causing major headaches with tuning and setting up slay undead correctly. Base = Damage Mod (100 is base, so 240 = 140% more) Limit = Proc Rate - Value is divided by 10000 for a Float %. e.g. 1700 becomes 0.17 (Or 17% proc rate). Damage bonus should be additive not std::max as AA, Spells and Item bonuses should stack. e.g. Slay Undead RK3 240 + Holy Forge 140 should = 380 (280% damage)
Kinglykrab
approved these changes
Jul 7, 2024
catapultam-habeo
pushed a commit
to The-Heroes-Journey-EQEMU/Server
that referenced
this pull request
Jul 12, 2024
Previous change did not account for the modern slay undead and holyforge spells. Reverted some of the changes and cleaned up others. Rule Renamed (Default value was incorrect, this was a clean way to fix that) - SlayDamageAdjustment -> SlayDamageMultiplier Also added a rate multiplier RULE_REAL(Combat, SlayRateMultiplier, 1.0, "Slay Rate Adjustments - Multiply final slay rate check by this value. Default: 1.0") Fixed the ordering of the constants for the slay undead SPA that were backwards and causing major headaches with tuning and setting up slay undead correctly. Base = Damage Mod (100 is base, so 240 = 140% more) Limit = Proc Rate - Value is divided by 10000 for a Float %. e.g. 1700 becomes 0.17 (Or 17% proc rate). Damage bonus should be additive not std::max as AA, Spells and Item bonuses should stack. e.g. Slay Undead RK3 240 + Holy Forge 140 should = 380 (280% damage)
catapultam-habeo
pushed a commit
to The-Heroes-Journey-EQEMU/Server
that referenced
this pull request
Jul 14, 2024
Previous change did not account for the modern slay undead and holyforge spells. Reverted some of the changes and cleaned up others. Rule Renamed (Default value was incorrect, this was a clean way to fix that) - SlayDamageAdjustment -> SlayDamageMultiplier Also added a rate multiplier RULE_REAL(Combat, SlayRateMultiplier, 1.0, "Slay Rate Adjustments - Multiply final slay rate check by this value. Default: 1.0") Fixed the ordering of the constants for the slay undead SPA that were backwards and causing major headaches with tuning and setting up slay undead correctly. Base = Damage Mod (100 is base, so 240 = 140% more) Limit = Proc Rate - Value is divided by 10000 for a Float %. e.g. 1700 becomes 0.17 (Or 17% proc rate). Damage bonus should be additive not std::max as AA, Spells and Item bonuses should stack. e.g. Slay Undead RK3 240 + Holy Forge 140 should = 380 (280% damage)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previous change did not account for the modern slay undead and holyforge spells.
Reverted some of the changes and cleaned up others.
Rule Renamed (Default value was incorrect, this was a clean way to fix that) - SlayDamageAdjustment -> SlayDamageMultiplier
Also added a rate multiplier
RULE_REAL(Combat, SlayRateMultiplier, 1.0, "Slay Rate Adjustments - Multiply final slay rate check by this value. Default: 1.0")
Fixed the ordering of the constants for the slay undead SPA that were backwards and causing major headaches with tuning and setting up slay undead correctly.
Base = Damage Mod (100 is base, so 240 = 140% more) Limit = Proc Rate - Value is divided by 10000 for a Float %. e.g. 1700 becomes 0.17 (Or 17% proc rate).
Damage bonus should be additive not std::max as AA, Spells and Item bonuses should stack.
e.g. Slay Undead RK3 240 + Holy Forge 140 should = 380 (280% damage)
Type of change
Please delete options that are not relevant.
Checklist