-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add Barter/Buyer Features #4405
Conversation
Adds barter and buyer features, for ROF2 only at this time including item compensation
Remove FKs from buyer tables
Update for quantity purchases not correctly providing multi items. Update for Find Buyer functionality based on zone instancing. Update buyer messaging Update buyer LORE duplicate check
5397eb7
to
c33e4cb
Compare
WFH has been using this a bit, all issues have been addressed so far. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great fucking work!
I barely need to make review comments this time around. I'm so damn impressed in how much you've learned, your attention to detail and how much you've done for this community in the past year alone. Thank you for being so willing to learn, receptive to feedback, be so on top of everything and pump out huge feature gaps we've needed for such a long time.
Adds barter and buyer features, for ROF2 only at this time including item compensation. Would appreciate a review and others testing.
Allows for the following:
Buyer support within the bazaar (version 0 and 1) instances
Barter support including searching and buying from within and outside the bazaar
Type of change
Please delete options that are not relevant.
Testing
Here is a short demo of the functionality.
https://youtu.be/4d4fZsMhemQ
This has also been running in the wild for a week or so. Positive results.
Clients tested:
RoF2 Only. This will break existing buyer/barter for previous clients. Not sure if it was broadly used. I intend to enable for UF, Ti should there be demand.
Checklist