Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Fix] Fix Lua Client FilteredMessage #4437

Merged
merged 1 commit into from
Jul 31, 2024
Merged

[Bug Fix] Fix Lua Client FilteredMessage #4437

merged 1 commit into from
Jul 31, 2024

Conversation

Kinglykrab
Copy link
Contributor

Description

  • @fryguy503 pointed out that he was having issues with client:FilteredMessage due to it saying he was using an invalid overload like below.
    image
    image

Type of change

  • Bug fix

Testing

image

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

fryguy503
fryguy503 approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@fryguy503 fryguy503 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fryguy503 fryguy503 merged commit 2cf5bae into master Jul 31, 2024
2 checks passed
@fryguy503 fryguy503 deleted the bug_fix/lua_client_filteredmessage branch July 31, 2024 23:39
@Akkadius Akkadius mentioned this pull request Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fryguy503 fryguy503 fryguy503 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kinglykrab @fryguy503