[Bug Fix] client_max_level allow leveling to end of level #4455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a method that leverages client_max_level (e.g. Max Level by bucket / qglobal / quest API) it would stop xp at 0% into the level rather than maximum xp for the level. This could pose an issue where: If you had a max level of 65 via a databucket and a raid zone required level 65, one death would de-level them and potentially prevent them from entering the zone. I reorganized the code to leverage the existing max_level logic which allows max xp in the max level. I also cleaned up the overall functions formating (Mostly brackets and implied if statements).
Kinglykrab
approved these changes
Aug 20, 2024
N0ctrnl
added a commit
to N0ctrnl/VAServer
that referenced
this pull request
Aug 27, 2024
This was causing characters to de-level when gaining experience and was missed as part of EQEmu#4455
6 tasks
Kinglykrab
pushed a commit
that referenced
this pull request
Aug 27, 2024
This was causing characters to de-level when gaining experience and was missed as part of #4455
Merged
Akkadius
pushed a commit
to The-Heroes-Journey-EQEMU/Server
that referenced
this pull request
Aug 27, 2024
When using a method that leverages client_max_level (e.g. Max Level by bucket / qglobal / quest API) it would stop xp at 0% into the level rather than maximum xp for the level. This could pose an issue where: If you had a max level of 65 via a databucket and a raid zone required level 65, one death would de-level them and potentially prevent them from entering the zone. I reorganized the code to leverage the existing max_level logic which allows max xp in the max level. I also cleaned up the overall functions formating (Mostly brackets and implied if statements).
Akkadius
pushed a commit
to The-Heroes-Journey-EQEMU/Server
that referenced
this pull request
Aug 27, 2024
This was causing characters to de-level when gaining experience and was missed as part of EQEmu#4455
catapultam-habeo
pushed a commit
to The-Heroes-Journey-EQEMU/Server
that referenced
this pull request
Sep 5, 2024
When using a method that leverages client_max_level (e.g. Max Level by bucket / qglobal / quest API) it would stop xp at 0% into the level rather than maximum xp for the level. This could pose an issue where: If you had a max level of 65 via a databucket and a raid zone required level 65, one death would de-level them and potentially prevent them from entering the zone. I reorganized the code to leverage the existing max_level logic which allows max xp in the max level. I also cleaned up the overall functions formating (Mostly brackets and implied if statements).
catapultam-habeo
added a commit
to The-Heroes-Journey-EQEMU/Server
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using a method that leverages client_max_level (e.g. Max Level by bucket / qglobal / quest API) it would stop xp at 0% into the level rather than maximum xp for the level.
This could pose an issue where: If you had a max level of 65 via a databucket and a raid zone required level 65, one death would de-level them and potentially prevent them from entering the zone.
I reorganized the code to leverage the existing max_level logic which allows max xp in the max level.
I also cleaned up the overall functions formating (Mostly brackets and implied if statements).
Type of change
Please delete options that are not relevant.
Testing
Checklist