Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Cleanup] Optimization Code Cleanup #4489

Merged
merged 9 commits into from
Sep 30, 2024

Conversation

Akkadius
Copy link
Member

@Akkadius Akkadius commented Sep 28, 2024

Description

This cleans up server side optimization code.

  • Simplifies code interfaces
  • Reduces duplication
  • Consolidates code into clear functions that describe their purpose
  • Makes code easier to read and understand

Documentation associated with this code https://docs.eqemu.io/developer/server-optimizations-blog/

Type of change

  • Code Cleanup

Testing

Attach images and describe testing done to validate functionality.

Clients tested:

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

zone/npc.cpp Outdated Show resolved Hide resolved
@Kinglykrab Kinglykrab force-pushed the akkadius/code-optimizations-cleanup branch from e4b3e9f to abdbdb5 Compare September 30, 2024 22:13
@Kinglykrab Kinglykrab merged commit bcd943a into master Sep 30, 2024
2 checks passed
@Kinglykrab Kinglykrab deleted the akkadius/code-optimizations-cleanup branch September 30, 2024 22:34
catapultam-habeo pushed a commit to The-Heroes-Journey-EQEMU/Server that referenced this pull request Oct 6, 2024
* Initial push

* More

* More

* Further simplify

* More cleanup

* More consolidation

* Fix

* Update

* Update npc.cpp

---------

Co-authored-by: Kinglykrab <kinglykrab@gmail.com>
catapultam-habeo pushed a commit to The-Heroes-Journey-EQEMU/Server that referenced this pull request Oct 6, 2024
* Initial push

* More

* More

* Further simplify

* More cleanup

* More consolidation

* Fix

* Update

* Update npc.cpp

---------

Co-authored-by: Kinglykrab <kinglykrab@gmail.com>
@Akkadius Akkadius mentioned this pull request Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants