Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS feeds timestamp not matching timestamp when dataset updated #237

Closed
emmerbodc opened this issue Jan 2, 2025 · 3 comments · Fixed by #248
Closed

RSS feeds timestamp not matching timestamp when dataset updated #237

emmerbodc opened this issue Jan 2, 2025 · 3 comments · Fixed by #248

Comments

@emmerbodc
Copy link

Describe the bug
The RSS feed timestamp doesn't match when the dataset got updates

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://linkedsystems.uk/erddap/tabledap/Ziggy_670_R.html
  2. Click on https://linkedsystems.uk/erddap/rss/Ziggy_670_R.rss
  3. Scroll down to
    Mon, 30 Dec 2024 08:33:57 GMT
    <title>This dataset changed 2024-12-30T08:33:57Z</title>
  4. See error - The dataset updated on 02-Jan-2025 07:33 but the RSS feed dataset timestamp is behind a few days.

Expected behavior
I expect the RSS timestamp to match the timestamp of when the dataset updated.

Screenshots
If applicable, add screenshots to help explain your problem.

Server

  • ERDDAP, Version 2.25

Desktop (please complete the following information):

  • Windows
  • Browser - Chrome
@ChrisJohnNOAA
Copy link
Contributor

Currently the rss is updated when the dataset is reloaded. For datasets using file updates, I do think it should be updated when a file changes. I'll look into adding that.

I also want to make sure the current updates are happening properly.

What is reloadEveryNMinutes set to for that dataset? If that is a very large number, you should be able to improve the rss generation by lowering it (until a version of ERDDAP is available with a fix).
Are you using the new SAX parser (true in setup.xml)?
Are you using the shared watch service (true in setup.xml)?

@thogar-computer
Copy link

Cheers, @ChrisJohnNOAA, for the reply.

We don't currently have those fields (SAX/shared watch) set in our setup.xml, so it looks like we are a little behind in that regard.

We have reloadEveryNMinutes set at 10080. we can look to reduce that.

@ChrisJohnNOAA
Copy link
Contributor

SAX and shared watch are optional. In 2.25_1, shared watch is defaulted to on. I was asking mostly to make sure I know what code paths you are using.

As for the change to reloadEveryNMinutes, that is a temporary fix. I intend to have the update logic update the RSS feed in 2.26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants