Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have file updates trigger RSS changes and Subscription actions. #248

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

ChrisJohnNOAA
Copy link
Contributor

Description

Dataset updates triggered by file changes using the watch system did not trigger RSS or subscriptions. This is counter to user expectations. The stated reasoning in a code comment was to avoid spammy changes for datasets that change frequently. I also did not see an explanation for users about this behavior. So this change is bringing the RSS and subscription systems in line with both the documentation and user expectations.

I recognize that this changes behavior in a way that could cause excessive notifications and/or load. There is a new parameter "updateSubsRssOnFileChanges" that will allow admins to disable this behavior if needed.

Documentation will be added once the big documentation update is settled.

Fixes #237

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ChrisJohnNOAA ChrisJohnNOAA merged commit d842433 into ERDDAP:main Jan 28, 2025
1 check passed
@ChrisJohnNOAA ChrisJohnNOAA deleted the rss_updates branch January 28, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RSS feeds timestamp not matching timestamp when dataset updated
1 participant