Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compiler warnings in 1.9.0 #2092

Merged
merged 1 commit into from
Dec 22, 2024
Merged

fix compiler warnings in 1.9.0 #2092

merged 1 commit into from
Dec 22, 2024

Conversation

svigerske
Copy link
Collaborator

  • clarify precedence in if condition
  • declare local function static

@svigerske
fix compiler warnings
2130896 
- clarify if condition
- declare local function static
@svigerske svigerske changed the base branch from master to latest December 22, 2024 12:03
@svigerske svigerske merged commit 18c62a8 into latest Dec 22, 2024
270 checks passed
@svigerske svigerske deleted the fix-warnings branch December 22, 2024 12:04
jajhall
jajhall reviewed Dec 22, 2024
View reviewed changes
Copy link
Member

@jajhall jajhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, there are a couple of other comparisons in the pipeline that I'll declare static

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jajhall jajhall jajhall left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svigerske @jajhall