Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sonnar_scanner.yml workflow #85

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Fix Sonnar_scanner.yml workflow #85

merged 1 commit into from
Oct 7, 2023

Conversation

mg-diego
Copy link
Contributor

@mg-diego mg-diego commented Oct 6, 2023

Fix Sonar Scanner workflow config

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

Sonnar_scanner.yml file was wrongly configured and all the code analysis were being link to the main branch instead of the pull request:
image

No pull request appeared at https://sonarcloud.io/project/pull_requests_list?id=ERNI-Academy_net6-automation-testware
image

Now the Pull Requests appear at the dashboard:
image

And the output is automatically written as a comment in the PR:
image

@mg-diego mg-diego requested a review from LopezMDidac as a code owner October 6, 2023 18:06
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@mg-diego mg-diego merged commit b438e24 into main Oct 7, 2023
7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/sonar-scanner branch October 7, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant