-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gravity and the "coordinates" section #39
Comments
@nusbaume Thanks for starting the discussion on this topic. I've had some time to think about it and do some reading and I have a few thoughts. First of all, as you suggest, there are a few different meanings of "gravitational acceleration" as a variable name in earth system modeling. Admittedly the subtleties in how and when these are used are a bit outside my wheelhouse, but there are at least three different definitions of gravitational acceleration from what I can ascertain:
It does seem wise to support at least two different standard names for gravitational acceleration: a constant (definition 1 above) and a vertically varying gravitational acceleration (definition 2 above), since these both seem to have at least some active use in earth system modeling. Definition 1 would better fit in the "constants" section, while definition 2 would have to appear elsewhere. RE: gravity as a "coordinate", it makes some sense with respect to definition 2 listed above, where gravity monotonically decreases with height. I do think that this can be misleading, however with a better description/definition I think its presence in this section could be justified. I don't think it belongs in the same section as "state variables", since it is not really a temporal variable in the same way that other traditional state variables are. So it's unclear to me where this variable would fit if not in the "coordinates" section. |
Added a new "scalar" gravitational acceleration standard name, and move the variable version into the state_variables section. I also fixed some typos and updated some other standard names as described in the fix typos issue. I should note that one standard name was changed slightly more than what was described in the issue at a scientist's request. Fixes #39 Fixes #11
Currently the standard name
gravitational_acceleration
is located under thecoordinates
section. However, I at least tend to not think of gravity as a coordinate, which then led to a discussion of what a "coordinate" actually means, at least in CCPP standard name world, which might be good to write down somewhere. To start the discussion I can think of two possibilities for what constitutes a "coordinate":latitude
andlongitude
in the current dictionary file would classify as "coordinates".cell_area
andcell_weight
would also be "coordinate" variables.If we use definition 2 above then
gravitational_acceleration
could also stay given that is generally only a function of the distance from the planet's gravitational center. However, one could also make the argument that if simulating non-Earth planets then the planet's mass also comes into play, which would then mean thatgravitational_acceleration
might be better included in a different section, likestate_variables
.Finally, although in reality gravity varies as a function of one's location in space, many models treat it as a constant. Would it also be beneficial to include a new standard name, say
standard_acceleration_of_gravity
, to represent this model constant?Anyways, happy to hear any thoughts or opinions on this topic. Thanks!
The text was updated successfully, but these errors were encountered: