Add new cloud standard name rule, and update cloud_area_fraction #37
Conversation
nusbaume
requested review from
cacraigucar,
mkavulich,
dudhia,
ligiabernardet,
grantfirl and
climbfuji
There was a problem hiding this comment.
I'd prefer non_convective be changed to either nonconvective or non-convective. I've seen it hyphenated or combined, but never separated with a space, which is what the underscore is representing. Also, I think that we're probably going to need a more general variable at some point that includes all clouds (including convective).
|
@grantfirl That's a good point! I've gone ahead and replaced |
standard_names.xml
Outdated
| @@ -354,7 +354,9 @@ | |||
| <standard_name name="mass_content_of_cloud_liquid_water_in_atmosphere_layer"> | |||
| <type kind="kind_phys" units="kg m-2">real</type> | |||
| </standard_name> | |||
| <standard_name name="cloud_area_fraction_in_atmosphere_layer"> | |||
| <standard_name | |||
| name="non-convective_cloud_area_fraction_in_atmosphere_layer" | |||
There was a problem hiding this comment.
This violates the Standard Name Rules.
Rule 2 states that standard names must follow the CF metadata rules for constructing standard names. This document states:
"Standard names consist of lower-letters, digits and underscores, and begin with a letter. Upper case is not used."
Please remove dashes in standard names.
There was a problem hiding this comment.
@gold2718 Good catch! I've gone ahead and removed the dash from the standard names.
Also, given that I am probably not going to be the only one who violates rule 2, I wonder if it would be worth adding a Github Action that checks that all of a PR's standard names are compliant? I'll go ahead and make a new issue so folks can discuss it there.
This pull request adds a new rule specifying that unless stated otherwise, the word
cloudmeans all cloud phases and types.Also, it was brought up by @grantfirl That the standard name
cloud_area_fractionas used in the UFS doesn't include convective clouds, so the standard name was updated, along with standard names that appeared directly related, to specify that convective clouds are not included.Finally, I am not strongly tied to the specific wording of either the new rule or the updated standard names, and so am happy to change them to whatever people prefer.