Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ESMF config file for multiple stream #140

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

uturuncoglu
Copy link
Collaborator

Description of changes

This PR fixes ESMF config format to provide multiple stream to CDEPS. It just affects UFS application at this point since this format only used under UFS.

Specific notes

Contributors other than yourself, if any:

CDEPS Issues Fixed (include github issue #): #139

Are there dependencies on other component PRs

  • CIME (list)
  • CMEPS (list)

Are changes expected to change answers?

  • bit for bit
  • different at roundoff level
  • more substantial

Any User Interface Changes (namelist or namelist defaults changes)?

  • Yes
  • No

Testing performed: Testing is done under UFS since this option is only used there.

  • (required) aux_cdeps
    • machines and compilers:
    • details (e.g. failed tests):
  • (optional) CESM prealpha test
    • machines and compilers
    • details (e.g. failed tests):

Hashes used for testing:

@uturuncoglu uturuncoglu self-assigned this Dec 30, 2021
@uturuncoglu
Copy link
Collaborator Author

@mvertens this is one line changes that fix the reading stream namelist file when it is provided in ESMF config format. This is working with UFS DATM+NoahMP configuration but i am testing again after updating merging branch with CDEPS master.

@uturuncoglu
Copy link
Collaborator Author

@mvertens I check it with the latest version and it seems okay. If you don't mind could you review this PR. I am planing to update the CDEPS under UFS NoahMP work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants