first step - reorder pio_init and move to ensemble_driver #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billsacks
added a commit
to billsacks/CMEPS
that referenced
this pull request
Jul 5, 2022
This will be needed for ESCOMP#305, where this variable is now referenced from another subroutine as well.
10 tasks
mvertens
requested changes
Jul 6, 2022
cesm/nuopc_cap_share/shr_pio_mod.F90
Outdated
| allocate(io_compid(ncomps)) | ||
| allocate(io_compname(ncomps)) | ||
| allocate(iosystems(ncomps)) | ||
| call ESMF_LogWrite(trim(subname)//": called", ESMF_LOGMSG_INFO) |
There was a problem hiding this comment.
Comment - ' Determine if my task is an async IO task'
cesm/nuopc_cap_share/shr_pio_mod.F90
Outdated
|
|
||
| call NUOPC_DriverGetComp(driver, compList=gcomp, rc=rc) | ||
| if (chkerr(rc,__LINE__,u_FILE_u)) return | ||
| driverpecount = 0 |
There was a problem hiding this comment.
Be consistent - put in an else here like below.
cesm/nuopc_cap_share/shr_pio_mod.F90
Outdated
|
|
||
| total_comps = size(gcomp) | ||
| if(associated(gcomp)) then |
cesm/nuopc_cap_share/shr_pio_mod.F90
Outdated
| total_comps = 0 | ||
| endif | ||
|
|
||
| call MPI_AllReduce(MPI_IN_PLACE, total_comps, 1, MPI_INTEGER, & |
There was a problem hiding this comment.
If there is an async IO component, this enables that component to know the number of driver components. If there is not an async IO component this really does not do anything.
cesm/driver/ensemble_driver.F90
Outdated
| call ESMF_LogSetError(ESMF_RC_ARG_BAD, msg=msgstr, line=__LINE__, file=__FILE__, rcToReturn=rc) | ||
| return | ||
| endif | ||
|
|
||
| if(pio_async_iotasks > 0 .and. .not. asyncIO_available) then |
There was a problem hiding this comment.
Write a message to the driver log file saying that you are using async io
It would be helpful to have this in log output
mvertens
approved these changes
Jul 6, 2022
|
@jedwards4b - is this PR still relevant - if so should it be merged - or closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add an InitializeIO phase to the ensemble_driver, this allows ESMF to control the ASYNCIO tasks internally.
Specific notes
It requires however that components do not do IO initialization until the realize phase so the cice and mosart component PRs: ESCOMP/MOSART#55
ESCOMP/CICE#18 must be merged first.
Contributors other than yourself, if any:
CMEPS Issues Fixed (include github issue #):
Are changes expected to change answers? bfb
Any User Interface Changes
Testing performed
Testing performed if application target is CESM:
Tested CESM prealpha cheyenne against cesm2_3_alpha09c baseline
Testing performed if application target is UFS-coupled:
Testing performed if application target is UFS-HAFS:
Hashes used for testing: