A fix for #346 so that LND2ROF_FMAPNAME will be used #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekluzek
commented
Apr 12, 2023
| <values> | ||
| <value>unset</value> | ||
| <value>$LND2ROF_FMAPNAME</value> | ||
| <value samegrid_lnd_rof='true'>idmap</value> |
There was a problem hiding this comment.
As this is written, samegrid_lnd_rof will override the LND2ROF_FMPANAME value. This is probably correct, but means there is hidden behavior where the LND2ROF_FMAPNAME value that the user sets is ignored.
There was a problem hiding this comment.
The one time this samegrid_lnd_rof comes up is for the nldas2_rnldas2_mnldas2 grid and I made sure with the new code it gives idmap as it should for that case.
fischer-ncar
approved these changes
Apr 13, 2023
jedwards4b
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Simple changes so that LND2ROF_FMAPNAME and ROF2LND_FMAPNAME will be used to fix the mapping for mizuRoute.
Specific notes
Contributors other than yourself, if any:
CMEPS Issues Fixed (include github issue #):
Fixes #346
Are changes expected to change answers? b4b (unless you use mapping files)
Any User Interface Changes (namelist or namelist defaults changes)?
XML variables LND2ROF_FMAPNAME and ROF2LND_FMAPNAME are now used
Testing performed
Testing performed if application target is CESM:
with CTSM add_mizuRoute branch. ctsm5.1.dev114-40-g3c288c96c
ccs_config_cesm0.0.52
cime6.0.75
This resolves the mizuRoute issue: ESCOMP/mizuRoute#339
Check nuopc.runconfig for the test SMS_D_Ld1.nldas2_rnldas2_mnldas2.I2000Clm50Sp.cheyenne_intel.clm-default and make sure it gives idmap for rof2lnd_map and lnd2rof_map.