Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download show filename #37

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Download show filename #37

merged 3 commits into from
Sep 12, 2024

Conversation

svenrdz
Copy link
Collaborator

@svenrdz svenrdz commented Feb 1, 2024

Resolves #33

Fixes an issue with boolean config entries: setting it to either true or false from the CLI would make them evaluate to True since in python, conversion of x: str to bool is the same as len(x) > 0, so special handling is required.

@svenrdz svenrdz marked this pull request as ready for review February 5, 2024 16:58
@svenrdz svenrdz added the enhancement New feature or request label Jul 17, 2024
@svenrdz svenrdz merged commit 49c1127 into main Sep 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a "filename" column to the download queue (feature request)
1 participant