-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ufs_release_v1.1: remove unnecessary/incorrect configuration options for Cheyenne for the UFS; downgrade Intel 19.x.y to 18.m.n on Cheyenne, Gaea, Orion #3713
Conversation
…he UFS; revert Intel back to Intel-18.0.5 on Cheyenne
…s/config_batch.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the base branch of this PR. (I know you acknowledged this in your initial comment, but seeing this PR into master makes me nervous, and I want to mark this as "request changes" until you fix that.)
We are discussing this right now in the MRW App release telecon, @uturuncoglu will take care of it. |
@climbfuji I created a branch called ufs_release_v1.1 and you could point your PR to that branch. Thanks. |
@uturuncoglu you should be able to create the new documentation version yourself. Please see https://github.com/esmci/cime/wiki/Working-with-Sphinx-and-reStructuredText for details. I just added a section on how to add a new version. Let me know if you run into trouble. |
@billsacks thanks for the doc. I'll try and let you know if I have any problem. |
@uturuncoglu I changed the target branch to |
@climbfuji okay that is great. @billsacks if you don't mind could you merge it. I have no rights to merge it. |
@billsacks I created the doc and push to gh-pages but I could not see it in the drop down menu. I also updated versions/versions.json file. May be it is just a issue related with the browser. |
@billsacks i fixed the issue. now it is fine. thanks for your help. |
Description
This PR removes a whole bunch of unnecessary/incorrect configuration options for Cheyenne for the UFS and reverts Intel back to Intel-18.0.5 on Cheyenne, Gaea, Orion.
Beforehand, the CIME regression tests failed frequently in
chgres_cube.exe
for the highest resolution cases, see description here: ufs-community/ufs-mrweather-app#190With this change and the associated change in the ufs-weather-model and NCEPLIBS-external (documentation only), the regression tests ran successfully (tried one time thus far, will conduct multiple runs to make sure I wasn't just lucky).
The PR also replaces a few tabs with whitespaces for consistent formatting in
config/ufs/machines/config_machines.xml
.Note that we will need to (re-)create tag
ufs-v1.1.0
(or whatever the CIME convention is; this is what we use for all the UFS components and external libraries, and what is also consistent with MRW App release 1.0).