Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom user-defined location for custom CMOR tables #1625

Merged
merged 9 commits into from
Jun 20, 2022

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Jun 8, 2022

Description

This PR allows the specification of a custom location for the custom CMOR tables in the config-developer.yml file (using the custom key).

Closes #1623

Link to documentation:


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added the cmor Related to the CMOR standard label Jun 8, 2022
@schlunma schlunma self-assigned this Jun 8, 2022
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #1625 (c9943b3) into main (1d94671) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1625      +/-   ##
==========================================
+ Coverage   91.38%   91.40%   +0.01%     
==========================================
  Files         204      204              
  Lines       11173    11188      +15     
==========================================
+ Hits        10211    10226      +15     
  Misses        962      962              
Impacted Files Coverage Δ
esmvalcore/cmor/table.py 94.29% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d94671...c9943b3. Read the comment docs.

@sloosvel
Copy link
Contributor

How is this going? Looks quite useful, but unfortunately now that all tests are passing, I have to continue with the release procedure. So, apologies but this won't be included at the end.

@schlunma
Copy link
Contributor Author

The code is finished, just need to add some bits of doc and a tiny test. Would love to hear the opinion of @zklaus before I go on, though!

Don't worry, this doesn't need to go into rc1. If we need an rc2 (which is more than likely given past experiences), we can still include this.

@ESMValGroup ESMValGroup deleted a comment from sloosvel Jun 15, 2022
@schlunma
Copy link
Contributor Author

Since there are no objections I will proceed with this PR now.

@schlunma schlunma requested a review from sloosvel June 15, 2022 18:35
@schlunma schlunma marked this pull request as ready for review June 15, 2022 18:35
@sloosvel sloosvel added this to the v2.6.0 milestone Jun 16, 2022
Copy link
Contributor

@sloosvel sloosvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested for the following cases:

  • Not setting the custom directory in config-developer
  • Setting the custom directory as a relative path
  • Setting the custom directory in a custom location

Works in all three cases as expected. Further comments and reviews are welcome, but I will merge on Monday if no one opposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmor Related to the CMOR standard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom user-defined location for custom CMOR tables
2 participants