-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom user-defined location for custom CMOR tables #1625
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1625 +/- ##
==========================================
+ Coverage 91.38% 91.40% +0.01%
==========================================
Files 204 204
Lines 11173 11188 +15
==========================================
+ Hits 10211 10226 +15
Misses 962 962
Continue to review full report at Codecov.
|
How is this going? Looks quite useful, but unfortunately now that all tests are passing, I have to continue with the release procedure. So, apologies but this won't be included at the end. |
The code is finished, just need to add some bits of doc and a tiny test. Would love to hear the opinion of @zklaus before I go on, though! Don't worry, this doesn't need to go into |
Since there are no objections I will proceed with this PR now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested for the following cases:
- Not setting the custom directory in config-developer
- Setting the custom directory as a relative path
- Setting the custom directory in a custom location
Works in all three cases as expected. Further comments and reviews are welcome, but I will merge on Monday if no one opposes.
Description
This PR allows the specification of a custom location for the custom CMOR tables in the
config-developer.yml
file (using thecustom
key).Closes #1623
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: