Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct build-and-deploy-on-pypi action #1634

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Correct build-and-deploy-on-pypi action #1634

merged 2 commits into from
Jun 13, 2022

Conversation

sloosvel
Copy link
Contributor

@sloosvel sloosvel commented Jun 13, 2022

Description

Corrects an error in the build and deploy on pypi action and increase version to v2.6.0rc2.

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #1634 (8c27f20) into main (71ac7ee) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1634   +/-   ##
=======================================
  Coverage   91.38%   91.38%           
=======================================
  Files         204      204           
  Lines       11173    11173           
=======================================
  Hits        10211    10211           
  Misses        962      962           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71ac7ee...8c27f20. Read the comment docs.

@sloosvel sloosvel merged commit 1d94671 into main Jun 13, 2022
@sloosvel sloosvel deleted the dev_correct_action branch June 13, 2022 14:57
@zklaus
Copy link

zklaus commented Jun 14, 2022

Please do not ignore the checklist. Do not approve PRs with open items on the checklist. It will be very difficult in the changelog to understand what this PR did.

@schlunma schlunma changed the title Correct action Correct build-and-deploy-on-pypi action Jun 14, 2022
@schlunma schlunma added the bug Something isn't working label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants