-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rotated coordinate grids and tas
and pr
for CORDEX datasets
#1765
Conversation
…ValCore into dev_cordex_fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked at the fixes yet, but this looks great! Thanks for the work. I left a few minor comments and I have one more that I couldn't attach to any code:
Most __init__.py
files have a short oneliner at the top, but tests/integration/cmor/_fixes/cordex/__init__.py
is empty. Should we add the usual one-liner also there?
Co-authored-by: Klaus Zimmermann <klaus.zimmermann@smhi.se>
Co-authored-by: Klaus Zimmermann <klaus.zimmermann@smhi.se>
…ValCore into dev_cordex_fixes
Ok, I think I addressed everything @bouweandela |
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
Description
This PR adds metadata fixes for CORDEX data, that may break the checker or the concatenation of historical+scenario data, as well as fixing a bug that prevented the loading of the X-hourly tables in the CORDEX project. It also solves issues with rotated coordinate grids using the
py-cordex
package to access the correct grid information per each domain.Closes #1764
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
- [ ] 🧪 and 🛠 Documentation is available- [ ] 🛠 Any changed dependencies have been added or removed correctlyTo help with the number pull requests: