Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rotated coordinate grids and tas and pr for CORDEX datasets #1765

Merged
merged 88 commits into from
Dec 19, 2022

Conversation

sloosvel
Copy link
Contributor

@sloosvel sloosvel commented Oct 20, 2022

Description

This PR adds metadata fixes for CORDEX data, that may break the checker or the concatenation of historical+scenario data, as well as fixing a bug that prevented the loading of the X-hourly tables in the CORDEX project. It also solves issues with rotated coordinate grids using the py-cordex package to access the correct grid information per each domain.

Closes #1764

Link to documentation:


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@sloosvel sloosvel added cmor Related to the CMOR standard fix for dataset Related to dataset-specific fix files labels Dec 16, 2022
@sloosvel sloosvel added this to the v2.8.0 milestone Dec 16, 2022
Copy link

@zklaus zklaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at the fixes yet, but this looks great! Thanks for the work. I left a few minor comments and I have one more that I couldn't attach to any code:

Most __init__.py files have a short oneliner at the top, but tests/integration/cmor/_fixes/cordex/__init__.py is empty. Should we add the usual one-liner also there?

esmvalcore/cmor/_fixes/cordex/cordex_fixes.py Outdated Show resolved Hide resolved
esmvalcore/cmor/_fixes/cordex/cordex_fixes.py Show resolved Hide resolved
esmvalcore/cmor/_fixes/cordex/cordex_fixes.py Outdated Show resolved Hide resolved
esmvalcore/cmor/_fixes/cordex/cordex_fixes.py Outdated Show resolved Hide resolved
esmvalcore/cmor/_fixes/cordex/cordex_fixes.py Outdated Show resolved Hide resolved
esmvalcore/cmor/check.py Outdated Show resolved Hide resolved
@sloosvel
Copy link
Contributor Author

Ok, I think I addressed everything @bouweandela

Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
@bouweandela bouweandela merged commit 7b5e40f into main Dec 19, 2022
@bouweandela bouweandela deleted the dev_cordex_fixes branch December 19, 2022 17:01
@bouweandela
Copy link
Member

Thanks for the great work @sloosvel @pepcos and @zklaus 🥳 Really awesome that we're finally getting CORDEX to work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmor Related to the CMOR standard fix for dataset Related to dataset-specific fix files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataset problem: CORDEX metadata issues
5 participants