Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Github Actions] Fix Monitor Tests Github Action #2135

Merged
merged 4 commits into from
Jul 13, 2023

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Jul 13, 2023

Description

For some reason the monitor tests GA workflow got a yaml syntax error, this made the test unusable, this fixes it.

Closes #2134


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #2135 (a6701e5) into main (2de1a2a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2135   +/-   ##
=======================================
  Coverage   93.09%   93.09%           
=======================================
  Files         237      237           
  Lines       12795    12795           
=======================================
  Hits        11911    11911           
  Misses        884      884           

@valeriupredoi valeriupredoi changed the title [Github Actions][DNM] Try fix Monitor Tests Github Action [Github Actions] Fix Monitor Tests Github Action Jul 13, 2023
@valeriupredoi valeriupredoi marked this pull request as ready for review July 13, 2023 09:35
@valeriupredoi valeriupredoi added bug Something isn't working testing labels Jul 13, 2023
@valeriupredoi valeriupredoi added this to the v2.10.0 milestone Jul 13, 2023
Copy link
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@valeriupredoi
Copy link
Contributor Author

Many thanks @remi-kazeroni 🍺

@valeriupredoi valeriupredoi merged commit 1abaf8e into main Jul 13, 2023
@valeriupredoi valeriupredoi deleted the force-monitor-test branch July 13, 2023 10:24
@zklaus zklaus removed the bug Something isn't working label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Github Actions] Monitor tests action stopped running
3 participants