Add ch4 surface custom cmor table entry #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New file to define the surface methane measurements.
Adding a test for the new custom cmor table "ch4s"
Codecov Report
@@ Coverage Diff @@
## main #2168 +/- ##
=======================================
Coverage 93.10% 93.10%
=======================================
Files 237 237
Lines 12822 12822
=======================================
Hits 11938 11938
Misses 884 884 |
remi-kazeroni
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Nice job, @hb326! Looks good to me 👍 Just a very minor suggestion before the merge
Co-authored-by: Rémi Kazeroni <remi.kazeroni@dlr.de>
Thanks, @remi-kazeroni! |
valeriupredoi
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
danke @hb326 - Remi, let me know when you happy so I merges 🍺
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a custom cmor table entry for surface methane data (monthly mean values), and a test for this new entry.
Closes #2164
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.