-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changelog and update version number for v2.10.0rc1 #2249
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2249 +/- ##
=======================================
Coverage 93.47% 93.47%
=======================================
Files 238 238
Lines 12932 12932
=======================================
Hits 12088 12088
Misses 844 844 |
yay 🥳 🎈 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good! One minor comment from me 🍺
Updated branch with new draft-release-notes helper script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice already, but it could use some improvement in how the entries are grouped.
gotta give it to you two for being so attentive wrt Changelog - I've seen a lot of packages (big ones, not itty bitty ones) that don't even include one, and just point the user to some rando hash lists 🎖️ 🍻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for re-ordering, looks much better now! Just a few more suggestions on improving the formatting.
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
Description
Update release version and add changelog for the upcoming v2.10.0 release.
Link to documentation: https://esmvaltool--2249.org.readthedocs.build/projects/ESMValCore/en/2249/changelog.html#v2-10-0
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: