-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More lazy fixes and preprocessing functions #2325
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2325 +/- ##
==========================================
+ Coverage 93.82% 93.97% +0.15%
==========================================
Files 240 240
Lines 13289 13273 -16
==========================================
+ Hits 12468 12473 +5
+ Misses 821 800 -21 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Bouwe, LGTM! Just some minor comments from my side.
Co-authored-by: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
brill work, fellas 🍻 |
Description
Various small improvements in lazy data computations by using coordinate methods
has_bounds()
,core_points()
,core_bounds()
where possible.Related to #674 and #42
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: