Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Numpy2] Support for
numpy==2.0.0
#2395base: main
Are you sure you want to change the base?
[Numpy2] Support for
numpy==2.0.0
#2395Changes from 46 commits
8930af0
a3e0632
233eb67
3687ea0
bf8dff5
29284bc
23429bc
50910b4
4d5d1eb
9fb584a
91a87ed
6eb3d00
ade96ca
ac75b84
d36350a
5dfa45a
baedee8
5f91615
038099d
ccb8f2f
882c1cd
6d9cda5
e3e2e25
30c99e5
98ee116
0e2799b
03a46fa
af8944e
6a8fe23
e849a73
3ec3fe5
26a5228
ecf68f8
c10ce96
f822bb8
061a4fb
a4707ef
266781a
73d455b
3007575
7386b7e
bf01de0
043407a
a3ccff6
aefb52c
1741727
4afc351
6464ecf
85b2aa4
05dea66
64da79d
ea3c702
0b2e975
b345843
55edd79
400ccc4
e6073eb
803017d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this backwards-compatible? If yes, do we need this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it is, functionally and it returns the same sort of structure, only typed differently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this work with
360.0
instead ofnp.int32(360)
? The points should be floats, not integers, so to me this makes much more sense. If this works, you can also remove the commentThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure, will test - but I agree about points' types indeed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nopers, a float there throws this:
so we either np.int32 the 360 or we np.float the left member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is not backwards-compatible? How does the error look like? It might make sense to adapt this in the actual code so the error message still looks nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it is, as it is now, ie the test does what it says on the lid for both numpy<2 and numpy>=2, here's the failed test for numpy>=2 if we don't change to forced typing: