-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load data only once for ESMPy regridders #2418
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2418 +/- ##
=======================================
Coverage 94.51% 94.51%
=======================================
Files 246 246
Lines 14020 14023 +3
=======================================
+ Hits 13251 13254 +3
Misses 769 769 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Bouwe, looks great!
Would it maybe make sense to include that into v2.11.0? This sounds like a serious performance issue.
@chrisbillowsMO @ehogan Would it be possible to include this in the upcoming v2.11 release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and a very good spotting, cheers @bouweandela and @schlunma
Description
Realize the data only once for the ESMPy regridders.
Closes ESMValGroup/ESMValTool#3590
Test recipe:
With these changes, the recipe takes less than a minute to run on my laptop. I did not wait for the process to complete (killed it after about 10 minutes), but reportedly it takes about an hour without these changes.
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: