Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make volume calculation in preprocessor function volume_statistics lazy #2436

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented May 26, 2024

Description

Make calculating the volume lazy.

Closes #647


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela added preprocessor Related to the preprocessor dask related to improvements using Dask labels May 26, 2024
Copy link

codecov bot commented May 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.51%. Comparing base (8d3d366) to head (b0a20ae).
Report is 40 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2436   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files         246      246           
  Lines       14024    14027    +3     
=======================================
+ Hits        13255    13258    +3     
  Misses        769      769           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bouweandela bouweandela marked this pull request as ready for review May 26, 2024 13:22
@bouweandela bouweandela requested a review from schlunma May 26, 2024 13:22
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, no further comments 🚀

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

luvly jubly 🍺

@valeriupredoi valeriupredoi merged commit 8e2ef15 into main Jun 4, 2024
7 checks passed
@valeriupredoi valeriupredoi deleted the lazy-volume-stats-with-calculated-volume branch June 4, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dask related to improvements using Dask preprocessor Related to the preprocessor
Projects
Development

Successfully merging this pull request may close these issues.

Make preprocessor function volume_statistics lazy
3 participants